Run 790 add gke installation script #14
Conversation
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| image: |
There was a problem hiding this comment.
You dont need all this file if line 20 is the only change from the defaults
There was a problem hiding this comment.
I wonder if you need a file at all if you change only one field. It can be changed directly form the CLI
There was a problem hiding this comment.
I do need it because this is the values file we are using for helm install, and we can't omit any of those fields.
If you want, we can use the default installation and then change all those values ourselves with the python script.
| patch_runaiconfig(dcgm_exporter_namespace) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() |
There was a problem hiding this comment.
I saw what you did in here. The only problem I have is with the hard adding of the text. I mean you are adding
path: /home/kubernetes/bin/nvidia
type: Directory
name: nvidia
right after volumeMounts:
But who guarentee they are going to be in there? And that the indentetion will stay the same in all versions?
If you already write it in python why not work directly with kubernetes client?
Or alternatively parse the string into yaml, add the field and then serialize it to yaml?
No description provided.