Add new metric magento_products_by_type_count_total #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the PR. We'll look into this shortly! |
VladyslavSikailo
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Hi @schmengler
Thank you for your Pull Request!
Just a minor update is required, may I ask you to check it?
Thanks!
I wondered if I submitted a PR in my sleep unknowingly :D that comment was for @scolandrea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a new metric
magento_products_by_type_count_totalto the extension. This metric gives a clear view of the count of products broken down by product type with the label product_type.Because of how helpful this metric is for projects I am working on now, I would be thankful if a new release of extension could be considered after adding this PR :)