Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrokenCronJobCountAggregator #44

Conversation

DmitryFurs
Copy link
Contributor

Fixed an error in the logs:

[2024-11-04T11:23:07.622790+00:00] rar_prometheus_metric_logger.ERROR: AggregateMetricsCron: Unable to process jobCode:magento_cronjob_broken_count_total SQLSTATE[HY000]: General error: 1525 Incorrect TIMESTAMP value: 'NULL', query was: SELECT `main_table`.* FROM `cron_schedule` AS `main_table` WHERE (status='pending') AND (executed_at='NULL') AND (finished_at='NULL') [] []

There are no IS and IS NOT filter types.: https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Data/Collection/AbstractDb.php#L571-L585

@DmitryFurs DmitryFurs force-pushed the fix-broken-cron-job-count-aggregator branch from 0c35fb2 to 7007200 Compare November 4, 2024 12:19
@VladyslavSikailo VladyslavSikailo requested review from VladyslavSikailo and removed request for VladyslavSikailo November 6, 2024 16:40
@DavidLambauer
Copy link
Member

LGTM. Thank you @DmitryFurs

@DavidLambauer DavidLambauer merged commit d092414 into run-as-root:master Nov 7, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants