Nothing to see here

runejs · Apr 20, 2021 · 7ff0593 · 7ff0593
1 parent 8f5847a
commit 7ff0593
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/game-engine/world/actor/player/player.ts b/src/game-engine/world/actor/player/player.ts
@@ -600,7 +600,7 @@ export class Player extends Actor {
         let showInConsole = false;
         if(typeof options === 'boolean') {
             showDialogue = true;
-        } else {
+        } else if(options) {
             showDialogue = options.dialogue || false;
             showInConsole = options.console || false;
         }

diff --git a/src/plugins/skills/woodcutting/woodcutting.plugin.ts b/src/plugins/skills/woodcutting/woodcutting.plugin.ts
@@ -9,10 +9,11 @@ import { randomBetween } from '@engine/util/num';
 import { colorText } from '@engine/util/strings';
 import { colors } from '@engine/util/colors';
 import { rollBirdsNestType } from '@engine/world/skill-util/harvest-roll';
-import { cache, world } from '@engine/game-server';
+import { world } from '@engine/game-server';
 import { soundIds } from '@engine/world/config/sound-ids';
 import { Axe, getAxe, HarvestTool } from '@engine/world/config/harvest-tool';
 import { TaskExecutor } from '@engine/world/action';
+import { findItem } from '@engine/config';
 
 
 const canActivate = (task: TaskExecutor<ObjectInteractionAction>, taskIteration: number): boolean => {
@@ -77,7 +78,7 @@ const activate = (task: TaskExecutor<ObjectInteractionAction>, taskIteration: nu
 
         const percentNeeded = tree.baseChance + toolLevel + actor.skills.woodcutting.level;
         if(successChance <= percentNeeded) {
-            const targetName: string = cache.itemDefinitions.get(tree.itemId).name.toLowerCase();
+            const targetName: string = findItem(tree.itemId).name.toLowerCase();
 
             if(actor.inventory.hasSpace()) {
                 const itemToAdd = tree.itemId;