Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error when opening quest journal #239

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Fixed error when opening quest journal #239

merged 3 commits into from
Dec 6, 2020

Conversation

markbmullins
Copy link
Contributor

Fixed error when opening quest journal

An error with the way quests were fetched from the main quest list caused an error when opening the quest journal. That has been fixed, along with adding a guard clause so the journal doesn't open if a quest does not exist yet.

Fixes Issue 238

Copy link
Member

@Tynarus Tynarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks!

@Tynarus Tynarus merged commit 362b522 into runejs:develop Dec 6, 2020
@Tynarus Tynarus added the bug Something isn't working label Dec 6, 2020
@markbmullins markbmullins deleted the quest-journal-fix branch December 6, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening quest journal fails and throws an error
2 participants