1.0.0-alpha.3 RC - Update Dependencies and use Biome for Linting and Formatting #436
+32,887
−39,147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJacobHolden
changed the title
DrJacobHolden
force-pushed
the
update-dependencies-and-migrate-to-biome
branch
from
5b55925 to
cf59412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely look at this bad boy commit by commit 😅
I had to make a lot of compromises in the Biome setup - I've set rules which are frequently violated but are desirable to "warn" and future PRs can address these individually. (This PR is big enough lol)
I removed the dependency on @runejs/store which was not used and added back the dependency on @runejs/filestore which is used (and was being implicitly included by @runejs/update-server)
I fixed a number of type issues - several which were surfaced due to the removal of
anytypes in the sub-projects.A few bugs as well - which is exciting (the system works!).
On my MacBook:
docker-composeworks and allows me to login and outnpm run startworks and allows me to login and outCurrently blocked until the following PRs are merged and new package versions are released: