Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and migrate to biome #3

Conversation

DrJacobHolden
Copy link

Removes the ESLint package and project and replaces it with Biome to handle both formatting and linting.

I've modified the Biome config to use single quotes and 4 space indentation so as to minimise noise in the diff.

I tidied up the dependencies as they were quite outdated and several of them had been abandoned (mostly due to Node adopting or surpassing the functionality in modern releases).

Each of the commands runs after adding the 435 assets required - although not without some errors (not sure if that's expected / I missed some files - or - I broke something, hopefully not).

The TypeORM package needs to be updated to the latest >0.3 due to a number of security vulnerabilities. There is a breaking API change I'm not entirely sure how to resolve. You can read about it here (search for you must explicitly define a column marked as primary).

Better-sqlite3 was a real PITA - not supporting Apple Silicon on any version officially supported by TypeORM - for this reason I had to add legacy-peer-deps=true to enable npm install to run with the latest version of the package. As far as I can tell - this works fine.

@DrJacobHolden
Copy link
Author

Closing this as store is not yet in use by the main project - instead keen to proceed with: runejs/filestore#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants