Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate lake project #4748

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Generate lake project #4748

merged 11 commits into from
Jan 31, 2025

Conversation

tothtamas28
Copy link
Contributor

  • Make cookiecutter a runtime dependency
  • Add logic for project generation
  • Add integration test for project generatiion

@tothtamas28 tothtamas28 self-assigned this Jan 29, 2025
@tothtamas28 tothtamas28 requested a review from JuanCoRo January 29, 2025 21:06
@tothtamas28 tothtamas28 mentioned this pull request Jan 30, 2025
Draft
@tothtamas28 tothtamas28 marked this pull request as ready for review January 30, 2025 16:33
@JuanCoRo
Copy link
Member

How does the workflow of generating the Lean files look like? A user will run a k command on a kompiled definition, and that will output a Lean 4 project containing the generated Lean files. Is this correct? Is there anything I'm missing? Thanks!

@tothtamas28
Copy link
Contributor Author

How does the workflow of generating the Lean files look like?

The user kompiles a K definition, then points the Python script to the definition directory to generate the lake project from it.

@tothtamas28 tothtamas28 requested a review from JuanCoRo January 31, 2025 11:26
JuanCoRo
JuanCoRo approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@JuanCoRo JuanCoRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 1f2715a into develop Jan 31, 2025
18 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the klean-generate branch January 31, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanCoRo JuanCoRo JuanCoRo approved these changes

Assignees

@tothtamas28 tothtamas28

Labels
automerge lean4-backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tothtamas28 @JuanCoRo