wip: replace PuzzleTheme with PuzzleThemeData

Also enforcing static types everywhere.

Author: russmatney

data.pandora

@@ -423,6 +423,10 @@
 					"puzzle_scene": {
 						"type": "resource",
 						"value": "res://src/themes/winter/WinterPuzzle.tscn"
+					},
+					"puzzle_theme_data": {
+						"type": "resource",
+						"value": "res://src/themes/winter/WinterThemeData.tres"
 					}
 				}
 			},

project.godot

@@ -33,6 +33,14 @@ GodotSteam="*res://src/GodotSteam.gd"
 Debug="*res://addons/bones/Debug.gd"
 Juice="*res://addons/bones/Juice.gd"
 
+[debug]
+
+gdscript/warnings/untyped_declaration=1
+gdscript/warnings/inferred_declaration=1
+gdscript/warnings/unsafe_property_access=1
+gdscript/warnings/unsafe_method_access=1
+gdscript/warnings/unsafe_call_argument=1
+
 [display]
 
 window/size/viewport_width=1280

src/PuzzleSet.gd

@@ -57,22 +57,23 @@ func data():
 var game_def: GameDef
 
 # returns a cached game_def, or parses a new one
-func get_game_def():
+func get_game_def() -> GameDef:
 	if game_def != null:
 		return game_def
 
 	game_def = Puzz.parse_game_def(get_puzzle_script_path())
 	return game_def
 
-func get_puzzles():
-	return get_game_def().puzzles.filter(func(puzz): return puzz.shape)
+func get_puzzles() -> Array[PuzzleDef]:
+	return get_game_def().puzzles.filter(func(puzz: PuzzleDef) -> bool: return puzz.shape != null)
 
-func get_puzzle(idx: int):
-	var puzzs = get_puzzles()
+func get_puzzle(idx: int) -> PuzzleDef:
+	var puzzs: Array[PuzzleDef] = get_puzzles()
 	if idx < len(puzzs):
 		return puzzs[idx]
 	else:
 		Log.warn("Requested out of range puzzle index", idx, self)
+		return
 
 # Attach an "analysis" to each level_def (game_def.puzzles[])
 # returns the game_def

src/hud/HUD.gd

@@ -1,4 +1,5 @@
 extends CanvasLayer
+class_name HUD
 
 ## vars ########################################################
 

src/menus/jumbotrons/PuzzleComplete.gd

@@ -1,21 +1,22 @@
 @tool
 extends Jumbotron
+class_name PuzzleComplete
 
 ## vars ############################################################
 
-@onready var puzzle_progress_panel = $%PuzzleProgressPanel
+@onready var puzzle_progress_panel: PuzzleProgressPanel = $%PuzzleProgressPanel
 var puzzle_set: PuzzleSet
 var start_puzzle_num: int
 var end_puzzle_num: int
 
 ## ready ############################################################
 
-func _ready():
+func _ready() -> void:
 	render()
 
 ## build puzzle list ############################################################
 
-func render():
+func render() -> void:
 	if not puzzle_set:
 		# puzzle_set = Store.get_puzzle_sets()[0]
 		Log.warn("No puzzle set found on PuzzleComplete scene")

src/menus/jumbotrons/PuzzleSetUnlocked.gd

@@ -1,5 +1,6 @@
 @tool
 extends Jumbotron
+class_name PuzzleUnlocked
 
 ## vars ############################################################
 

src/puzzle/GameDef.gd

@@ -4,24 +4,24 @@ class_name GameDef
 
 ## vars ########################################3333
 
-var puzzles = []
+var puzzles: Array[PuzzleDef] = []
 var legend: Dictionary
 var meta: Dictionary
 var raw: Dictionary
 var path: String
 
 ## init ########################################3333
 
-func _init(_path, parsed: Dictionary):
+func _init(_path: String, parsed: Dictionary) -> void:
 	if _path:
 		path = _path
 	raw = parsed
 	legend = parsed.legend
-	puzzles = parsed.puzzles.map(func(puzzle): return PuzzleDef.new(puzzle))
+	puzzles.assign(parsed.puzzles.map(func(puzzle: Dictionary) -> PuzzleDef: return PuzzleDef.new(puzzle)))
 
-## log.data() ########################################3333
+## to_pretty ########################################3333
 
-func data():
+func to_pretty() -> Dictionary:
 	return {path=path, obj=str(self), puzzles=len(puzzles)}
 
 ## helpers ########################################3333