Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove memoffset dependency. #164

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

aDotInTheVoid
Copy link
Contributor

std::mem::offset has been availible on stable since 1.77.0. memoffset uses this when compiled against a recent enough rustc.

Moving to the implementation in std lets me drop both memoffset and autocfg from my transitive dependencies.

@lnicola
Copy link
Member

lnicola commented Jun 1, 2024

Since we're here, we should probably add a rust-version key. You can ignore the CI error, it's a false positive.

@Veykril
Copy link
Member

Veykril commented Jun 1, 2024

And bump the version number in the Cargo.toml so CI does a release

`std::mem::offset` has been availible on stable since 1.77.0.
`memoffset` uses this when compiled against a recent enough rustc.

Moving to the implementation in `std` lets us drop both `memoffset` and `autocfg` from our dependencies.
@aDotInTheVoid
Copy link
Contributor Author

@Veykril do you want a minor or patch release? this crate doesn't have an MSRV policy.

@Veykril
Copy link
Member

Veykril commented Jun 3, 2024

Patch should be fine, I don't see any breaking changes isnce the last bump

@aDotInTheVoid
Copy link
Contributor Author

Done

@Veykril Veykril merged commit e2d2e93 into rust-analyzer:master Jun 3, 2024
1 check failed
@Veykril
Copy link
Member

Veykril commented Jun 3, 2024

Thanks!

@aDotInTheVoid aDotInTheVoid deleted the drop-memoffset-dep branch June 3, 2024 15:07
@aDotInTheVoid
Copy link
Contributor Author

Gah, the autopublish doesn't work due to false positives in invalid_reference_casting. They're fixed on nightly, but not beta (but are backport nominated). I don't need this on crates.io anytime soon, so I'm happy to wait for CI to become unborked, but it'll probably require a manual CI rerun of the specific commit (if you want v0.15.16 to correspond to that commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants