-
Notifications
You must be signed in to change notification settings - Fork 29
Implement listbanned method and test #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There are a few problems with this one. Primarily the integration test does not test anything because the vector in Can you fix that up and we'll go from there? Also:
Thanks |
oh my... Let me fix them up. |
a303ca2
to
66875fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better man.
12c00a4
to
afba694
Compare
I think something is still wrong here. If I comment out the fields in |
Woaw... Let check what is wrong. |
Thank you for pointing this out. seems the test was only checking if there is at least an element inside of the |
The JSON-RPC method
listbanned
does return a type. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than the type it returns, along with an integration test that calls this function.
Ref: #116