Prevent panic when db schema differs from migrations #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasFocke01
commented
Mar 6, 2025
| runner.abort_missing, | ||
| &runner.migration_table_name, | ||
| ); | ||
| let failed = unapplied_migrations.is_err(); |
There was a problem hiding this comment.
I had to assign failed up here, because borrowchecker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
sorry for just opening a pr without an issue linked.
I did this because the change i have done was pretty small.
I got this panic, when i applied a migration, then altered the database schema and ran the migration again.
I tracked the
unwrap()in question down to the changed file in the pr and just updated thefailedstate of the migration.This allows the user to catch the error and handle it himself.
Anything i should do different?