register: add mtinst register #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the definition for the `mtinst` Machine trap instruction CSR.
riscv/src/register/macros.rs
Outdated
| let exp_val = (bits & (mask << $start)) >> $start; | ||
|
|
||
| $crate::paste! { | ||
| assert_eq!(exp_val, exp_val); |
There was a problem hiding this comment.
Good catch, I missed it when doing a search-replace from an earlier version of the macro arm.
I fixed it 😓
rmsyn
force-pushed
the
riscv/register/mtinst
branch
from
ae83f9e to
57fec49
Compare
Adds a test macro branch for multi-bit register fields. Minor correction to the single-bit test macro for not assuming the field's initial value.
Adds basic unit tests for the `mtinst` CSR.
rmsyn
force-pushed
the
riscv/register/mtinst
branch
from
57fec49 to
5fc8d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the definition for the
mtinstMachine trap instruction CSR.Adds a test macro branch for multi-bit register fields.
Minor correction to the single-bit test macro for not assuming the field's initial value.
Adds basic unit tests for the
mtinstCSR.Related: #1