Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update trait.md and destructure_slice.md #191

Merged
merged 9 commits into from
May 8, 2024
Merged

update trait.md and destructure_slice.md #191

merged 9 commits into from
May 8, 2024

Conversation

WangMengabc
Copy link
Contributor

No description provided.

@WangMengabc WangMengabc changed the title update trait.md update trait.md and destructure_slice.md Apr 30, 2024
YangFong
YangFong requested changes May 7, 2024
View reviewed changes
src/trait.md Outdated Show resolved Hide resolved
src/flow_control/match/destructuring/destructure_slice.md Outdated Show resolved Hide resolved
src/flow_control/match/destructuring/destructure_slice.md Outdated Show resolved Hide resolved
src/flow_control/match/destructuring/destructure_slice.md Outdated Show resolved Hide resolved
src/flow_control/match/destructuring/destructure_slice.md Outdated Show resolved Hide resolved
src/flow_control/match/destructuring/destructure_slice.md Outdated Show resolved Hide resolved
@YangFong YangFong merged commit 34b81df into rust-lang-cn:master May 8, 2024
2 checks passed
@YangFong
Copy link
Member

YangFong commented May 8, 2024

两点建议：

  1. 提 PR，最好是新开分支，如果非要用 master，那么请保持最新状态，否则会有很多无意义的 commits。

  2. 除了不同意见，不必条条回复 review，修改好了，点击对应的 Resolve conversation 按钮即可。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangFong YangFong YangFong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WangMengabc @YangFong