feat: Add Level::None for omitting the header
#171
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When combined with an empty `title`, this results in the header being omitted entirely. This isn't what @epage suggested in rust-lang#167 since changing our rendering to pass in a custom header is a bigger refactor than what I've been able to get to. The goal of this change was to be very small without requiring bigger code changes on our end. Unfortunately, this is a breaking change, so I'm not sure what the appetite is for this. Fixes rust-lang#167
|
I have a practically identical change in #159 for very similar reasons :) |
|
Ah nice, whoops, missed that! |
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Jun 11, 2025
Summary: I want to use [annotate-snippets](https://github.com/rust-lang/annotate-snippets-rs) to format code snippets in error messages. Unfortunately, annotate-snippets [always prints a non-customizable level label](rust-lang/annotate-snippets-rs#167), and a [proposed patch](rust-lang/annotate-snippets-rs#171) to fix this has been sitting unreviewed since January. Ruff has forked annotate-snippets and applied this patch, along with a couple other bug fixes. We could do the same thing (fork annotate-snippets ourselves), but it's simpler for now to reuse the Ruff fork. I followed the instructions here to bring in a new Rust library: https://www.internalfb.com/wiki/Rust/Third_Party_Libraries/Adding_or_Updating_Libraries/. Reviewed By: yangdanny97 Differential Revision: D76367898 fbshipit-source-id: 2b4727790c8b7d1d7b7028bc34e2f577cef8864c
|
I'm also after pretty much the same change. Any chance this could be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combined with an empty
title, this results in the header beingomitted entirely.
This isn't what @epage suggested in #167 since changing our rendering to
pass in a custom header is a bigger refactor than what I've been able to
get to. The goal of this change was to be very small without requiring
bigger code changes on our end. Unfortunately, this is a breaking
change, so I'm not sure what the appetite is for this.
Fixes #167