Skip to content

build(core): allow windows-targets 0.53.0 #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build(core): allow windows-targets 0.53.0 #694

wants to merge 1 commit into from
+22 −22

Conversation

ErichDonGubler
Copy link
Contributor

@ErichDonGubler ErichDonGubler commented Jan 21, 2025 •
edited
Loading

Hard dependency on nagisa/rust_libloading#169.

@ErichDonGubler ErichDonGubler mentioned this pull request Jan 21, 2025
Draft
@ErichDonGubler
Copy link
Contributor Author

This PR is effectively ready for review, minus dependencies. A local cargo test --workspace --all-features WFM, so here's hoping CI is happy! 🤞🏻

@ErichDonGubler ErichDonGubler mentioned this pull request Jan 21, 2025
Draft
8 tasks
@workingjubilee
Copy link
Member

Looks like CI is indeed happy? Is this still a draft?

poking @ChrisDenton

@ErichDonGubler ErichDonGubler force-pushed the windows-targets-0.53 branch from 43e7db9 to ce6b657 Compare May 24, 2025 13:19
@ErichDonGubler
Copy link
Contributor Author

libloading 0.8.7 has been released, so this PR is now shippable.

@ErichDonGubler ErichDonGubler marked this pull request as ready for review May 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErichDonGubler @workingjubilee