Skip to content

Use rust-lang/rust instead of rust-lang-ci/rust for unrolled rollup build commit URLs #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 20, 2025

We have moved CI from rust-lang-ci/rust to rust-lang/rust, so this can be merged now.

Context: rust-lang/infra-team#188

@Kobzol Kobzol marked this pull request as ready for review May 23, 2025 11:18
@lqd
Copy link
Member

lqd commented May 27, 2025

CI commits don't usually last that long before being GCed by github, but will this impact bisecting through recent rollups that were still using rust-lang-ci?

@Kobzol
Copy link
Contributor Author

Kobzol commented May 27, 2025

I guess it could, yeah. It's just the URL that would be wrong. We could either provide both links, or test if the link is 404 (?), or add some check based on the date of the commit.

@lqd
Copy link
Member

lqd commented May 27, 2025

Maybe by the time this is merged, released, and people update there will be no more of these old CI commits to worry about 😅 -- and just the PR name itself will be found (which should be enough IME).

Otherwise this LGTM.

Spelling out the situation a bit in the changelog should be helpful in any case.

@Kobzol Kobzol force-pushed the move-to-rust-lang branch from 424e06d to 4464ef0 Compare May 27, 2025 09:30
@Kobzol
Copy link
Contributor Author

Kobzol commented May 27, 2025

Added a changelog entry and also the second URL in the printed log.

@Kobzol Kobzol force-pushed the move-to-rust-lang branch from 4464ef0 to 101e228 Compare May 27, 2025 09:33
Copy link
Collaborator

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I forget how long the perf builds are available (is it the same as regular commits?). I assume we can essentially revert this after that time?

@ehuss ehuss merged commit 957c6d3 into rust-lang:master May 27, 2025
4 checks passed
@Kobzol
Copy link
Contributor Author

Kobzol commented May 27, 2025

It should essentially be a regular try build commit, yeah.

@Kobzol Kobzol deleted the move-to-rust-lang branch May 27, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants