use extern "custom" on naked functions with a custom calling convention
#957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
naked-custom-abi
branch
2 times, most recently
from
b33dfd0 to
21d5f0f
Compare
tgross35
reviewed
Jun 14, 2025
There was a problem hiding this comment.
Thanks for putting this together! It was on my todo list but
I'm not sure whether the atomic functions in https://github.com/rust-lang/compiler-builtins/blob/master/compiler-builtins/src/aarch64_linux.rs follow the C abi, so I didn't touch them for now.
I believe they are actually the C ABI, or at least https://community.arm.com/arm-community-blogs/b/tools-software-ides-blog/posts/making-the-most-of-the-arm-architecture-in-gcc-10 has an example calling a similar function directly and they seem to obey the input register calling convention.
folkertdev
force-pushed
the
naked-custom-abi
branch
2 times, most recently
from
a592805 to
296ecf7
Compare
tgross35
reviewed
Jun 14, 2025
tgross35
approved these changes
Jun 14, 2025
tgross35
force-pushed
the
naked-custom-abi
branch
from
cb33487 to
e911a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether the atomic functions in https://github.com/rust-lang/compiler-builtins/blob/master/compiler-builtins/src/aarch64_linux.rs follow the C abi, so I didn't touch them for now.