db-dump: Reset sequences after data import #11506
Merged
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
eth3lbert
approved these changes
Jul 3, 2025
script/reset-sequences.sql
Outdated
Comment on lines
29
to
30
| -- Reset the sequence to the max value | ||
| PERFORM setval('public.' || rec.sequence_name, max_id); |
There was a problem hiding this comment.
FWIW, it might be worth commenting that the next value will be the set max_id + 1. This is because setval has two modes controlled by its optional third argument (which defaults to true), determining whether to add 1 to the next value.
There was a problem hiding this comment.
I slightly changed it to explicitly use the third argument. Without this for empty tables the next value would have been 2 instead of 1. I hope that makes it a bit clearer.
There was a problem hiding this comment.
ah yeah, you're right, thanks for the noticing!
This automatically resets all `id` column sequences to the maximum `id` column value of the corresponding table after the data was imported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically resets all
idcolumn sequences to the maximumidcolumn value of the corresponding table after the data was imported.Closes #10204