optionally collect compiler metrics #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
collect-metrics
branch
3 times, most recently
from
56c41dd to
0358ce2
Compare
GuillaumeGomez
approved these changes
May 13, 2025
|
Would be nice to have a test where the first build fails but the second succeeds to ensure that the metrics are not enabled the second time but not sure if it can be tested. If not, feel free to merge and thanks for the add! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft as a base for discussion.
Generally we want to separate the build output between builds / releases so I'm just using the target directory and copy over the json files afterwards.
What's missing is some kind of ICE protection, where we would retry the build without metrics in case of ICEs, or just collect metrics on the first try.
Also I would like to add tests.