Skip to content

Fix docs.rs onig_sys build #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Fix docs.rs onig_sys build #2822

merged 1 commit into from
May 16, 2025
+14 −25

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner May 15, 2025 10:59
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 15, 2025
syphar
syphar requested changes May 15, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, can you elaborate in the commit why we need the patch? what the error was and on what system?

@GuillaumeGomez GuillaumeGomez requested a review from syphar May 15, 2025 20:10
@GuillaumeGomez GuillaumeGomez force-pushed the onig_sys branch 2 times, most recently from fa9adf3 to 1105ac4 Compare May 15, 2025 20:29
@GuillaumeGomez
Copy link
Member Author

Fixed new clippy lint.

@GuillaumeGomez
Fix docs.rs onig_sys build error:
637ec11 
oniguruma/src/st.c:500:23: error: too many arguments to function 'func'; expected 0, have 3
@GuillaumeGomez
Copy link
Member Author

CI is happy! \o/

@syphar syphar merged commit a1a3d06 into rust-lang:master May 16, 2025
10 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 16, 2025
@GuillaumeGomez GuillaumeGomez deleted the onig_sys branch May 16, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

Assignees
No one assigned
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @syphar