Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visionOS Support #3568

Merged
merged 2 commits into from
Apr 26, 2024
Merged

visionOS Support #3568

merged 2 commits into from
Apr 26, 2024

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 30, 2024

In preparation of xrOS (visionOS) support as a tier 3 target, this makes libc buildable for this platform by mirroring iOS and other Apple target configurations.

See rust-lang/compiler-team#642

@rustbot
Copy link
Collaborator

rustbot commented Jan 30, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@agg23
Copy link
Contributor Author

agg23 commented Jan 30, 2024

Hm... I hadn't thought about cfgs failing because the target_os doesn't exist yet.

How is this supposed to work then? New T3 target gets added to Rust, cannot build (proper) libc, libc gets updated, Rust gets updated another time to pull that libc? Seems difficult.

@bors
Copy link
Contributor

bors commented Feb 3, 2024

☔ The latest upstream changes (presumably #3567) made this pull request unmergeable. Please resolve the merge conflicts.

@Urgau
Copy link
Member

Urgau commented Feb 14, 2024

Hm... I hadn't thought about cfgs failing because the target_os doesn't exist yet.

How is this supposed to work then? New T3 target gets added to Rust, cannot build (proper) libc, libc gets updated, Rust gets updated another time to pull that libc? Seems difficult.

@agg23 You can add an exception in the build.rs.

@JohnTitor
Copy link
Member

Could you squash commits into one? The changes look good!

@QuentinPerez
Copy link

Hi @JohnTitor,

The PR has been squashed, do you think that's something that can be merged soon ?

Swapped to visionOS target_os
@QuentinPerez
Copy link

Hi there,

Sorry for being impatient, but I really need to have this pull request merged. What is missing?

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 5, 2024
Add aarch64-apple-visionos and aarch64-apple-visionos-sim tier 3 targets

Introduces `aarch64-apple-visionos` and `aarch64-apple-visionos-sim` as tier 3 targets. This allows native development for the Apple Vision Pro's visionOS platform.

This work has been tracked in rust-lang/compiler-team#642. There is a corresponding `libc` change rust-lang/libc#3568 that is not required for merge.

Ideally we would be able to incorporate [this change](gimli-rs/object#626) to the `object` crate, but the author has stated that a release will not be cut for quite a while. Therefore, the two locations that would reference the xrOS constant from `object` are hardcoded to their MachO values of 11 and 12, accompanied by TODOs to mark the code as needing change. I am open to suggestions on what to do here to get this checked in.

# Tier 3 Target Policy

At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.

> A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

See [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
> * Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
> * If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

This naming scheme matches `$ARCH-$VENDOR-$OS-$ABI` which is matches the iOS Apple Silicon simulator (`aarch64-apple-ios-sim`) and other Apple targets.

> Tier 3 targets may have unusual requirements to build or use, but must not
  create legal issues or impose onerous legal terms for the Rust project or for
  Rust developers or users.
>  - The target must not introduce license incompatibilities.
>  - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`).
>  - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to besubject to any new license requirements.
>  - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
> - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

This contribution is fully available under the standard Rust license with no additional legal restrictions whatsoever. This PR does not introduce any new dependency less permissive than the Rust license policy.

The new targets do not depend on proprietary libraries.

> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This new target mirrors the standard library for watchOS and iOS, with minor divergences.

> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Documentation is provided in [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
> * This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
> * Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
> * In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I acknowledge these requirements and intend to ensure that they are met.

This target does not touch any existing tier 2 or tier 1 targets and should not break any other targets.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2024
Rollup merge of rust-lang#121419 - agg23:xrOS-pr, r=davidtwco

Add aarch64-apple-visionos and aarch64-apple-visionos-sim tier 3 targets

Introduces `aarch64-apple-visionos` and `aarch64-apple-visionos-sim` as tier 3 targets. This allows native development for the Apple Vision Pro's visionOS platform.

This work has been tracked in rust-lang/compiler-team#642. There is a corresponding `libc` change rust-lang/libc#3568 that is not required for merge.

Ideally we would be able to incorporate [this change](gimli-rs/object#626) to the `object` crate, but the author has stated that a release will not be cut for quite a while. Therefore, the two locations that would reference the xrOS constant from `object` are hardcoded to their MachO values of 11 and 12, accompanied by TODOs to mark the code as needing change. I am open to suggestions on what to do here to get this checked in.

# Tier 3 Target Policy

At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.

> A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

See [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
> * Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
> * If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

This naming scheme matches `$ARCH-$VENDOR-$OS-$ABI` which is matches the iOS Apple Silicon simulator (`aarch64-apple-ios-sim`) and other Apple targets.

> Tier 3 targets may have unusual requirements to build or use, but must not
  create legal issues or impose onerous legal terms for the Rust project or for
  Rust developers or users.
>  - The target must not introduce license incompatibilities.
>  - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`).
>  - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to besubject to any new license requirements.
>  - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
> - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

This contribution is fully available under the standard Rust license with no additional legal restrictions whatsoever. This PR does not introduce any new dependency less permissive than the Rust license policy.

The new targets do not depend on proprietary libraries.

> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This new target mirrors the standard library for watchOS and iOS, with minor divergences.

> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Documentation is provided in [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
> * This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
> * Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
> * In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I acknowledge these requirements and intend to ensure that they are met.

This target does not touch any existing tier 2 or tier 1 targets and should not break any other targets.
@agg23 agg23 changed the title xrOS support visionOS Support Apr 6, 2024
@agg23
Copy link
Contributor Author

agg23 commented Apr 6, 2024

Rust tier 3 target PR has merged.

I need to figure out what in this PR is breaking the musl builds.

RalfJung pushed a commit to RalfJung/miri that referenced this pull request Apr 6, 2024
Add aarch64-apple-visionos and aarch64-apple-visionos-sim tier 3 targets

Introduces `aarch64-apple-visionos` and `aarch64-apple-visionos-sim` as tier 3 targets. This allows native development for the Apple Vision Pro's visionOS platform.

This work has been tracked in rust-lang/compiler-team#642. There is a corresponding `libc` change rust-lang/libc#3568 that is not required for merge.

Ideally we would be able to incorporate [this change](gimli-rs/object#626) to the `object` crate, but the author has stated that a release will not be cut for quite a while. Therefore, the two locations that would reference the xrOS constant from `object` are hardcoded to their MachO values of 11 and 12, accompanied by TODOs to mark the code as needing change. I am open to suggestions on what to do here to get this checked in.

# Tier 3 Target Policy

At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.

> A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

See [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
> * Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
> * If possible, use only letters, numbers, dashes and underscores for the name. Periods (.) are known to cause issues in Cargo.

This naming scheme matches `$ARCH-$VENDOR-$OS-$ABI` which is matches the iOS Apple Silicon simulator (`aarch64-apple-ios-sim`) and other Apple targets.

> Tier 3 targets may have unusual requirements to build or use, but must not
  create legal issues or impose onerous legal terms for the Rust project or for
  Rust developers or users.
>  - The target must not introduce license incompatibilities.
>  - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`).
>  - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to besubject to any new license requirements.
>  - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
> - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

This contribution is fully available under the standard Rust license with no additional legal restrictions whatsoever. This PR does not introduce any new dependency less permissive than the Rust license policy.

The new targets do not depend on proprietary libraries.

> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This new target mirrors the standard library for watchOS and iOS, with minor divergences.

> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Documentation is provided in [src/doc/rustc/src/platform-support/apple-visionos.md](https://github.com/rust-lang/rust/blob/e88379034a0fe7d90a8f305bbaf4ad66dd2ce8dc/src/doc/rustc/src/platform-support/apple-visionos.md)

> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
> * This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
> * Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
> * In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

I acknowledge these requirements and intend to ensure that they are met.

This target does not touch any existing tier 2 or tier 1 targets and should not break any other targets.
@madsmtm
Copy link
Contributor

madsmtm commented Apr 10, 2024

I think this may need to be based on the libc-0.2 branch, as that's where we want it to go?

@agg23
Copy link
Contributor Author

agg23 commented Apr 10, 2024

Fixed the branch target. Still having the weird test failure, just in a slightly different way. Still don't know what to do about it.

@rudyrichter
Copy link

@agg23 I think #3660 unblocks things here

@madsmtm
Copy link
Contributor

madsmtm commented Apr 18, 2024

@agg23 could you rebase this on the latest master? Then I think the CI would build.

@agg23
Copy link
Contributor Author

agg23 commented Apr 18, 2024

It's not as straightforward as that, as the change happened to main, not libc-0.2. I have cherry picked the commit in question, though I am not sure if that's the right action to take.

@rudyrichter
Copy link

@JohnTitor should this be targeting the 0.2 or main(1.0) branch? which is slated to have a release in the near term?

@coolbluewater
Copy link

@JohnTitor, could you please respond so that this PR can move forward?

@JohnTitor
Copy link
Member

@JohnTitor should this be targeting the 0.2 or main(1.0) branch? which is slated to have a release in the near term?

Should be shipped on 0.2 as 1.0 would require much more time to release 👍

@JohnTitor, could you please respond so that this PR can move forward?

👋 Sorry, I've been OSSing in my spare time and failed to find time recently.

@JohnTitor JohnTitor added this pull request to the merge queue Apr 26, 2024
Merged via the queue into rust-lang:libc-0.2 with commit eb1bad8 Apr 26, 2024
57 checks passed
@coolbluewater
Copy link

Thanks! Do we know when this will appear in rust nightly?

@madsmtm
Copy link
Contributor

madsmtm commented Apr 27, 2024

Once the next release of libc happens, I'll post a PR to update it in rust-lang/rust

@madsmtm
Copy link
Contributor

madsmtm commented Apr 30, 2024

I've posted rust-lang/rust#124560.

I would like to respond to the rest of your comments, but such discussion is not appropriate on this issue. Are you on Zulip? Maybe you could DM me there?

EDIT: It appears that their comments have been removed.

bors referenced this pull request in rust-lang/cargo May 1, 2024
chore(deps): update compatible

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [annotate-snippets](https://togithub.com/rust-lang/annotate-snippets-rs) | workspace.dependencies | patch | `0.11.1` -> `0.11.2` |
| [anyhow](https://togithub.com/dtolnay/anyhow) | workspace.dependencies | patch | `1.0.81` -> `1.0.82` |
| [base64](https://togithub.com/marshallpierce/rust-base64) | workspace.dependencies | patch | `0.22.0` -> `0.22.1` |
| [color-print](https://gitlab.com/dajoha/color-print) | workspace.dependencies | patch | `0.3.5` -> `0.3.6` |
| [flate2](https://togithub.com/rust-lang/flate2-rs) | workspace.dependencies | patch | `1.0.28` -> `1.0.30` |
| [indexmap](https://togithub.com/indexmap-rs/indexmap) | workspace.dependencies | patch | `2` -> `2.2.6` |
| [jobserver](https://togithub.com/rust-lang/jobserver-rs) | workspace.dependencies | patch | `0.1.28` -> `0.1.31` |
| [libc](https://togithub.com/rust-lang/libc) | workspace.dependencies | patch | `0.2.153` -> `0.2.154` |
| [pathdiff](https://togithub.com/Manishearth/pathdiff) | workspace.dependencies | patch | `0.2` -> `0.2.1` |
| [percent-encoding](https://togithub.com/servo/rust-url) | workspace.dependencies | patch | `2.3` -> `2.3.1` |
| [pulldown-cmark](https://togithub.com/raphlinus/pulldown-cmark) | workspace.dependencies | patch | `0.10.2` -> `0.10.3` |
| [serde](https://serde.rs) ([source](https://togithub.com/serde-rs/serde)) | workspace.dependencies | patch | `1.0.197` -> `1.0.199` |
| [serde_json](https://togithub.com/serde-rs/json) | workspace.dependencies | patch | `1.0.115` -> `1.0.116` |
| [thiserror](https://togithub.com/dtolnay/thiserror) | workspace.dependencies | patch | `1.0.58` -> `1.0.59` |
| [time](https://time-rs.github.io) ([source](https://togithub.com/time-rs/time)) | workspace.dependencies | patch | `0.3` -> `0.3.36` |
| [toml_edit](https://togithub.com/toml-rs/toml) | workspace.dependencies | patch | `0.22.11` -> `0.22.12` |
| [unicode-width](https://togithub.com/unicode-rs/unicode-width) | workspace.dependencies | patch | `0.1.11` -> `0.1.12` |

---

### Release Notes

<details>
<summary>rust-lang/annotate-snippets-rs (annotate-snippets)</summary>

### [`v0.11.2`](https://togithub.com/rust-lang/annotate-snippets-rs/blob/HEAD/CHANGELOG.md#0112---2024-04-27)

[Compare Source](https://togithub.com/rust-lang/annotate-snippets-rs/compare/0.11.1...0.11.2)

##### Added

-   All public types now implement `Debug` [#&#8203;119](https://togithub.com/rust-lang/annotate-snippets-rs/pull/119)

</details>

<details>
<summary>dtolnay/anyhow (anyhow)</summary>

### [`v1.0.82`](https://togithub.com/dtolnay/anyhow/releases/tag/1.0.82)

[Compare Source](https://togithub.com/dtolnay/anyhow/compare/1.0.81...1.0.82)

-   Documentation improvements

</details>

<details>
<summary>marshallpierce/rust-base64 (base64)</summary>

### [`v0.22.1`](https://togithub.com/marshallpierce/rust-base64/blob/HEAD/RELEASE-NOTES.md#0221)

[Compare Source](https://togithub.com/marshallpierce/rust-base64/compare/v0.22.0...v0.22.1)

-   Correct the symbols used for the predefined `alphabet::BIN_HEX`.

</details>

<details>
<summary>dajoha/color-print (color-print)</summary>

### [`v0.3.6`](https://gitlab.com/dajoha/color-print/compare/v0.3.5...v0.3.6)

[Compare Source](https://gitlab.com/dajoha/color-print/compare/v0.3.5...v0.3.6)

</details>

<details>
<summary>rust-lang/flate2-rs (flate2)</summary>

### [`v1.0.30`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.30): - docs.rs pages should build again

[Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.29...1.0.30)

##### What's Changed

-   Fix typos by [`@&#8203;striezel](https://togithub.com/striezel)` in [https://github.com/rust-lang/flate2-rs/pull/406](https://togithub.com/rust-lang/flate2-rs/pull/406)
-   Update actions/checkout in GitHub Actions workflows to v4 by [`@&#8203;striezel](https://togithub.com/striezel)` in [https://github.com/rust-lang/flate2-rs/pull/407](https://togithub.com/rust-lang/flate2-rs/pull/407)
-   fix CI - `--all-features` wasn't tested and didn't work with arrival of `zlib-rs` by [`@&#8203;Byron](https://togithub.com/Byron)` in [https://github.com/rust-lang/flate2-rs/pull/405](https://togithub.com/rust-lang/flate2-rs/pull/405)

##### New Contributors

-   [`@&#8203;striezel](https://togithub.com/striezel)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/406](https://togithub.com/rust-lang/flate2-rs/pull/406)

**Full Changelog**: rust-lang/flate2-rs@1.0.29...1.0.30

### [`v1.0.29`](https://togithub.com/rust-lang/flate2-rs/releases/tag/1.0.29): - with new `zlib-rs` feature (~`zlib-ng` in Rust)

[Compare Source](https://togithub.com/rust-lang/flate2-rs/compare/1.0.28...1.0.29)

With the [new `zlib-rs`](https://togithub.com/memorysafety/zlib-rs) feature, a new backend is enabled that brings in a SIMD-accelerated Rust implementation.

##### What's Changed

-   Fix build for beta and nightly by [`@&#8203;JakubOnderka](https://togithub.com/JakubOnderka)` in [https://github.com/rust-lang/flate2-rs/pull/388](https://togithub.com/rust-lang/flate2-rs/pull/388)
-   Store `StreamWrapper::inner` as a raw pointer by [`@&#8203;icmccorm](https://togithub.com/icmccorm)` in [https://github.com/rust-lang/flate2-rs/pull/394](https://togithub.com/rust-lang/flate2-rs/pull/394)
-   Avoid redudant imports by [`@&#8203;Byron](https://togithub.com/Byron)` in [https://github.com/rust-lang/flate2-rs/pull/398](https://togithub.com/rust-lang/flate2-rs/pull/398)
-   add `zlib-rs` support via the `libz-rs-sys` C api for `zlib-rs` by [`@&#8203;folkertdev](https://togithub.com/folkertdev)` in [https://github.com/rust-lang/flate2-rs/pull/400](https://togithub.com/rust-lang/flate2-rs/pull/400)
-   Add tests to show BufRead can be used after decoding by [`@&#8203;jongiddy](https://togithub.com/jongiddy)` in [https://github.com/rust-lang/flate2-rs/pull/402](https://togithub.com/rust-lang/flate2-rs/pull/402)
-   release version 1.0.29: support for zlib-rs by [`@&#8203;folkertdev](https://togithub.com/folkertdev)` in [https://github.com/rust-lang/flate2-rs/pull/403](https://togithub.com/rust-lang/flate2-rs/pull/403)

##### New Contributors

-   [`@&#8203;JakubOnderka](https://togithub.com/JakubOnderka)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/388](https://togithub.com/rust-lang/flate2-rs/pull/388)
-   [`@&#8203;icmccorm](https://togithub.com/icmccorm)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/394](https://togithub.com/rust-lang/flate2-rs/pull/394)
-   [`@&#8203;folkertdev](https://togithub.com/folkertdev)` made their first contribution in [https://github.com/rust-lang/flate2-rs/pull/400](https://togithub.com/rust-lang/flate2-rs/pull/400)

**Full Changelog**: rust-lang/flate2-rs@1.0.28...1.0.29

</details>

<details>
<summary>rust-lang/libc (libc)</summary>

### [`v0.2.154`](https://togithub.com/rust-lang/libc/releases/tag/0.2.154)

[Compare Source](https://togithub.com/rust-lang/libc/compare/0.2.153...0.2.154)

#### What's Changed

-   Fix CI on v0.2 by [`@&#8203;JohnTitor](https://togithub.com/JohnTitor)` in [https://github.com/rust-lang/libc/pull/3589](https://togithub.com/rust-lang/libc/pull/3589)
-   \[Backport [#&#8203;3547](https://togithub.com/rust-lang/libc/issues/3547)] Add ioctl FS_IOC\_{G,S}{ETVERSION,ETFLAGS} for CSKY by [`@&#8203;Dirreke](https://togithub.com/Dirreke)` in [https://github.com/rust-lang/libc/pull/3572](https://togithub.com/rust-lang/libc/pull/3572)
-   Add Linux riscv64 HWCAP defines (libc-0.2) by [`@&#8203;Xeonacid](https://togithub.com/Xeonacid)` in [https://github.com/rust-lang/libc/pull/3580](https://togithub.com/rust-lang/libc/pull/3580)
-   Add missing MIPS R6 FS_IOC_\* definitions by [`@&#8203;chenx97](https://togithub.com/chenx97)` in [https://github.com/rust-lang/libc/pull/3591](https://togithub.com/rust-lang/libc/pull/3591)
-   Support posix_spawn on Android by [`@&#8203;pcc](https://togithub.com/pcc)` in [https://github.com/rust-lang/libc/pull/3602](https://togithub.com/rust-lang/libc/pull/3602)
-   \[0.2] Fix libc-tests for loongarch64 by [`@&#8203;heiher](https://togithub.com/heiher)` in [https://github.com/rust-lang/libc/pull/3607](https://togithub.com/rust-lang/libc/pull/3607)
-   visionOS Support by [`@&#8203;agg23](https://togithub.com/agg23)` in [https://github.com/rust-lang/libc/pull/3568](https://togithub.com/rust-lang/libc/pull/3568)
-   \[0.2] linux/musl: Add support for LoongArch64 by [`@&#8203;heiher](https://togithub.com/heiher)` in [https://github.com/rust-lang/libc/pull/3606](https://togithub.com/rust-lang/libc/pull/3606)
-   v0.2: Fix c_char on AIX by [`@&#8203;taiki-e](https://togithub.com/taiki-e)` in [https://github.com/rust-lang/libc/pull/3662](https://togithub.com/rust-lang/libc/pull/3662)
-   solarish adding SO_EXCLBIND constant. by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3651](https://togithub.com/rust-lang/libc/pull/3651)
-   \[0.2] Add SIG constants to espidf by [`@&#8203;Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik)` in [https://github.com/rust-lang/libc/pull/3658](https://togithub.com/rust-lang/libc/pull/3658)
-   add all android sysconf constants by [`@&#8203;fkm3](https://togithub.com/fkm3)` in [https://github.com/rust-lang/libc/pull/3656](https://togithub.com/rust-lang/libc/pull/3656)
-   feat: more \_PC_XXX constants for apple targets by [`@&#8203;SteveLauC](https://togithub.com/SteveLauC)` in [https://github.com/rust-lang/libc/pull/3649](https://togithub.com/rust-lang/libc/pull/3649)
-   feat: O_EXEC/O_SEARCH for apple platforms by [`@&#8203;SteveLauC](https://togithub.com/SteveLauC)` in [https://github.com/rust-lang/libc/pull/3668](https://togithub.com/rust-lang/libc/pull/3668)
-   \[0.2] Add constant AT_MINSIGSTKSZ by [`@&#8203;ur4t](https://togithub.com/ur4t)` in [https://github.com/rust-lang/libc/pull/3637](https://togithub.com/rust-lang/libc/pull/3637)
-   Haiku: synchronize with post R1-beta 4 changes in libc by [`@&#8203;nielx](https://togithub.com/nielx)` in [https://github.com/rust-lang/libc/pull/3638](https://togithub.com/rust-lang/libc/pull/3638)
-   adding getentropy/getrandom to dragonflybsd. by [`@&#8203;devnexen](https://togithub.com/devnexen)` in [https://github.com/rust-lang/libc/pull/3618](https://togithub.com/rust-lang/libc/pull/3618)
-   Move strftime, strftime_l, strptime to linux_like by [`@&#8203;pcc](https://togithub.com/pcc)` in [https://github.com/rust-lang/libc/pull/3600](https://togithub.com/rust-lang/libc/pull/3600)
-   update crate version to 0.2.154 by [`@&#8203;Dirreke](https://togithub.com/Dirreke)` in [https://github.com/rust-lang/libc/pull/3573](https://togithub.com/rust-lang/libc/pull/3573)

#### New Contributors

-   [`@&#8203;pcc](https://togithub.com/pcc)` made their first contribution in [https://github.com/rust-lang/libc/pull/3602](https://togithub.com/rust-lang/libc/pull/3602)
-   [`@&#8203;agg23](https://togithub.com/agg23)` made their first contribution in [https://github.com/rust-lang/libc/pull/3568](https://togithub.com/rust-lang/libc/pull/3568)
-   [`@&#8203;Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik)` made their first contribution in [https://github.com/rust-lang/libc/pull/3658](https://togithub.com/rust-lang/libc/pull/3658)
-   [`@&#8203;ur4t](https://togithub.com/ur4t)` made their first contribution in [https://github.com/rust-lang/libc/pull/3637](https://togithub.com/rust-lang/libc/pull/3637)

**Full Changelog**: rust-lang/libc@0.2.153...0.2.154

</details>

<details>
<summary>raphlinus/pulldown-cmark (pulldown-cmark)</summary>

### [`v0.10.3`](https://togithub.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.10.3)

[Compare Source](https://togithub.com/raphlinus/pulldown-cmark/compare/v0.10.2...v0.10.3)

The main change of this release is the `simd` feature was not being used in the escape functions  since the version 0.10 due to a mistake during the separation of the crate `pulldown-cmark-escape`.

The crate `pulldown-cmark-escape` has been updated to the version 0.10.1.

#### What's Changed

-   fix: fix dead code warning from nightly compiler by [`@&#8203;rhysd](https://togithub.com/rhysd)` in [https://github.com/pulldown-cmark/pulldown-cmark/pull/876](https://togithub.com/pulldown-cmark/pulldown-cmark/pull/876)
-   Eat all spaces after line break in link title by [`@&#8203;notriddle](https://togithub.com/notriddle)` in [https://github.com/pulldown-cmark/pulldown-cmark/pull/877](https://togithub.com/pulldown-cmark/pulldown-cmark/pull/877)
-   Mark `Rule` as a block item by [`@&#8203;notriddle](https://togithub.com/notriddle)` in [https://github.com/pulldown-cmark/pulldown-cmark/pull/879](https://togithub.com/pulldown-cmark/pulldown-cmark/pull/879)

**Full Changelog**: pulldown-cmark/pulldown-cmark@v0.10.2...v0.10.3

</details>

<details>
<summary>serde-rs/serde (serde)</summary>

### [`v1.0.199`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.199)

[Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.198...v1.0.199)

-   Fix ambiguous associated item when `forward_to_deserialize_any!` is used on an enum with `Error` variant ([#&#8203;2732](https://togithub.com/serde-rs/serde/issues/2732), thanks [`@&#8203;aatifsyed](https://togithub.com/aatifsyed))`

### [`v1.0.198`](https://togithub.com/serde-rs/serde/releases/tag/v1.0.198)

[Compare Source](https://togithub.com/serde-rs/serde/compare/v1.0.197...v1.0.198)

-   Support serializing and deserializing `Saturating<T>` ([#&#8203;2709](https://togithub.com/serde-rs/serde/issues/2709), thanks [`@&#8203;jbethune](https://togithub.com/jbethune))`

</details>

<details>
<summary>serde-rs/json (serde_json)</summary>

### [`v1.0.116`](https://togithub.com/serde-rs/json/releases/tag/v1.0.116)

[Compare Source](https://togithub.com/serde-rs/json/compare/v1.0.115...v1.0.116)

-   Make module structure comprehensible to static analysis ([#&#8203;1124](https://togithub.com/serde-rs/json/issues/1124), thanks [`@&#8203;mleonhard](https://togithub.com/mleonhard))`

</details>

<details>
<summary>dtolnay/thiserror (thiserror)</summary>

### [`v1.0.59`](https://togithub.com/dtolnay/thiserror/releases/tag/1.0.59)

[Compare Source](https://togithub.com/dtolnay/thiserror/compare/1.0.58...1.0.59)

-   Unblock testing of rustc `debug-fmt-detail` option ([#&#8203;297](https://togithub.com/dtolnay/thiserror/issues/297))

</details>

<details>
<summary>time-rs/time (time)</summary>

### [`v0.3.36`](https://togithub.com/time-rs/time/blob/HEAD/CHANGELOG.md#0336-2024-04-10)

[Compare Source](https://togithub.com/time-rs/time/compare/v0.3.35...v0.3.36)

##### # Fixed

-   `FormatItem` can be used as part of an import path. See [#&#8203;675] for details.

[#&#8203;675]: https://togithub.com/time-rs/time/issues/675

### [`v0.3.35`](https://togithub.com/time-rs/time/blob/HEAD/CHANGELOG.md#0335-2024-04-10)

[Compare Source](https://togithub.com/time-rs/time/compare/v0.3.34...v0.3.35)

##### Added

-   `Duration::checked_neg`
-   `ext::InstantExt`, which provides methods for using `time::Duration` with `std::time::Instant`

##### Changed

-   `Instant` is deprecated. It is recommended to use `std::time::Instant` directly, importing
    `time::ext::InstantExt` for interoperability with `time::Duration`.
-   `FormatItem` has been renamed to `BorrowedFormatItem`, avoiding confusion with `OwnedFormatItem`.
    An alias has been added for backwards compatibility.

##### Fixed

-   The weekday is optional when parsing RFC2822.
-   The range of sub-second values in `Duration` is documented correctly. The previous documentation
    contained an off-by-one error.
-   Leap seconds are now correctly handled when parsing ISO 8601.

</details>

<details>
<summary>toml-rs/toml (toml_edit)</summary>

### [`v0.22.12`](https://togithub.com/toml-rs/toml/compare/v0.22.11...v0.22.12)

[Compare Source](https://togithub.com/toml-rs/toml/compare/v0.22.11...v0.22.12)

</details>

<details>
<summary>unicode-rs/unicode-width (unicode-width)</summary>

### [`v0.1.12`](https://togithub.com/unicode-rs/unicode-width/compare/v0.1.11...v0.1.12)

[Compare Source](https://togithub.com/unicode-rs/unicode-width/compare/v0.1.11...v0.1.12)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
leftwo referenced this pull request in oxidecomputer/crucible May 14, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [libc](https://togithub.com/rust-lang/libc) | workspace.dependencies |
patch | `0.2.153` -> `0.2.154` |

---

### Release Notes

<details>
<summary>rust-lang/libc (libc)</summary>

###
[`v0.2.154`](https://togithub.com/rust-lang/libc/releases/tag/0.2.154)

[Compare
Source](https://togithub.com/rust-lang/libc/compare/0.2.153...0.2.154)

#### What's Changed

- Fix CI on v0.2 by [@&#8203;JohnTitor](https://togithub.com/JohnTitor)
in
[https://github.com/rust-lang/libc/pull/3589](https://togithub.com/rust-lang/libc/pull/3589)
- \[Backport
[#&#8203;3547](https://togithub.com/rust-lang/libc/issues/3547)] Add
ioctl FS_IOC\_{G,S}{ETVERSION,ETFLAGS} for CSKY by
[@&#8203;Dirreke](https://togithub.com/Dirreke) in
[https://github.com/rust-lang/libc/pull/3572](https://togithub.com/rust-lang/libc/pull/3572)
- Add Linux riscv64 HWCAP defines (libc-0.2) by
[@&#8203;Xeonacid](https://togithub.com/Xeonacid) in
[https://github.com/rust-lang/libc/pull/3580](https://togithub.com/rust-lang/libc/pull/3580)
- Add missing MIPS R6 FS_IOC_\* definitions by
[@&#8203;chenx97](https://togithub.com/chenx97) in
[https://github.com/rust-lang/libc/pull/3591](https://togithub.com/rust-lang/libc/pull/3591)
- Support posix_spawn on Android by
[@&#8203;pcc](https://togithub.com/pcc) in
[https://github.com/rust-lang/libc/pull/3602](https://togithub.com/rust-lang/libc/pull/3602)
- \[0.2] Fix libc-tests for loongarch64 by
[@&#8203;heiher](https://togithub.com/heiher) in
[https://github.com/rust-lang/libc/pull/3607](https://togithub.com/rust-lang/libc/pull/3607)
- visionOS Support by [@&#8203;agg23](https://togithub.com/agg23) in
[https://github.com/rust-lang/libc/pull/3568](https://togithub.com/rust-lang/libc/pull/3568)
- \[0.2] linux/musl: Add support for LoongArch64 by
[@&#8203;heiher](https://togithub.com/heiher) in
[https://github.com/rust-lang/libc/pull/3606](https://togithub.com/rust-lang/libc/pull/3606)
- v0.2: Fix c_char on AIX by
[@&#8203;taiki-e](https://togithub.com/taiki-e) in
[https://github.com/rust-lang/libc/pull/3662](https://togithub.com/rust-lang/libc/pull/3662)
- solarish adding SO_EXCLBIND constant. by
[@&#8203;devnexen](https://togithub.com/devnexen) in
[https://github.com/rust-lang/libc/pull/3651](https://togithub.com/rust-lang/libc/pull/3651)
- \[0.2] Add SIG constants to espidf by
[@&#8203;Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik) in
[https://github.com/rust-lang/libc/pull/3658](https://togithub.com/rust-lang/libc/pull/3658)
- add all android sysconf constants by
[@&#8203;fkm3](https://togithub.com/fkm3) in
[https://github.com/rust-lang/libc/pull/3656](https://togithub.com/rust-lang/libc/pull/3656)
- feat: more \_PC_XXX constants for apple targets by
[@&#8203;SteveLauC](https://togithub.com/SteveLauC) in
[https://github.com/rust-lang/libc/pull/3649](https://togithub.com/rust-lang/libc/pull/3649)
- feat: O_EXEC/O_SEARCH for apple platforms by
[@&#8203;SteveLauC](https://togithub.com/SteveLauC) in
[https://github.com/rust-lang/libc/pull/3668](https://togithub.com/rust-lang/libc/pull/3668)
- \[0.2] Add constant AT_MINSIGSTKSZ by
[@&#8203;ur4t](https://togithub.com/ur4t) in
[https://github.com/rust-lang/libc/pull/3637](https://togithub.com/rust-lang/libc/pull/3637)
- Haiku: synchronize with post R1-beta 4 changes in libc by
[@&#8203;nielx](https://togithub.com/nielx) in
[https://github.com/rust-lang/libc/pull/3638](https://togithub.com/rust-lang/libc/pull/3638)
- adding getentropy/getrandom to dragonflybsd. by
[@&#8203;devnexen](https://togithub.com/devnexen) in
[https://github.com/rust-lang/libc/pull/3618](https://togithub.com/rust-lang/libc/pull/3618)
- Move strftime, strftime_l, strptime to linux_like by
[@&#8203;pcc](https://togithub.com/pcc) in
[https://github.com/rust-lang/libc/pull/3600](https://togithub.com/rust-lang/libc/pull/3600)
- update crate version to 0.2.154 by
[@&#8203;Dirreke](https://togithub.com/Dirreke) in
[https://github.com/rust-lang/libc/pull/3573](https://togithub.com/rust-lang/libc/pull/3573)

#### New Contributors

- [@&#8203;pcc](https://togithub.com/pcc) made their first contribution
in
[https://github.com/rust-lang/libc/pull/3602](https://togithub.com/rust-lang/libc/pull/3602)
- [@&#8203;agg23](https://togithub.com/agg23) made their first
contribution in
[https://github.com/rust-lang/libc/pull/3568](https://togithub.com/rust-lang/libc/pull/3568)
- [@&#8203;Tevz-Beskovnik](https://togithub.com/Tevz-Beskovnik) made
their first contribution in
[https://github.com/rust-lang/libc/pull/3658](https://togithub.com/rust-lang/libc/pull/3658)
- [@&#8203;ur4t](https://togithub.com/ur4t) made their first
contribution in
[https://github.com/rust-lang/libc/pull/3637](https://togithub.com/rust-lang/libc/pull/3637)

**Full Changelog**:
rust-lang/libc@0.2.153...0.2.154

</details>
@tgross35 tgross35 added the main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. label Aug 13, 2024
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 17, 2024
Swapped to visionOS target_os

(apply <rust-lang#3568> to `main`)
[resolve conflicts - Trevor]
(cherry picked from commit b5b0f69)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
Swapped to visionOS target_os

(apply <rust-lang#3568> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit b5b0f69)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
Swapped to visionOS target_os

(apply <rust-lang#3568> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit b5b0f69)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
Swapped to visionOS target_os

(apply <rust-lang#3568> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit b5b0f69)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 28, 2024
Swapped to visionOS target_os

(apply <rust-lang#3568> to `main`)
[ resolve conflicts - Trevor ]
(cherry picked from commit b5b0f69)
@tgross35 tgross35 added main-applied This PR was merged against libc-0.2 and main has since been updated to include it and removed main-needs-cherry-pick This PR was merged against libc-0.2 but does not yet exist in main. labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main-applied This PR was merged against libc-0.2 and main has since been updated to include it S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants