Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common Linux ptrace definitions to linux_like/mod.rs #4030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbyzhang
Copy link
Contributor

Move common Linux ptrace definitions to linux_like/mod.rs.

Continuing from #3463

@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mbyzhang
Copy link
Contributor Author

Hi, any pointers on CI failures?

"full CI / Build Channels Linux (beta) " failed due to types like ::__u64 not present on wasm32-unknown-emscripten target. Any clean way I can add them?

"full CI / Docker Linux Tier2 (i686-unknown-linux-musl) (pull_request)" failed seemingly due to ptrace_syscall_info not present on musl. Why, since I already added it to common Linux definitions?

Thanks

@bors
Copy link
Contributor

bors commented Nov 14, 2024

☔ The latest upstream changes (presumably #3962) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor

Hi, any pointers on CI failures?

"full CI / Build Channels Linux (beta) " failed due to types like ::__u64 not present on wasm32-unknown-emscripten target. Any clean way I can add them?

Does emscripten even have ptrace (@hoodmane)? I think you might have to disable it on at least a few platforms.

"full CI / Docker Linux Tier2 (i686-unknown-linux-musl) (pull_request)" failed seemingly due to ptrace_syscall_info not present on musl. Why, since I already added it to common Linux definitions?

The struct comes uapi and not from the system libc, right? We have some old headers in CI, you might just need to disable it in build.rs.

@rustbot author

@hoodmane
Copy link
Contributor

Yeah Emscripten has no ptrace, nor any processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants