Skip to content

Conversation

Molot2032
Copy link
Contributor

Would fix #3107

  • The name passed to generated_link_name_override is no longer first modified by generated_name_override
  • Makes the mangled name for items available in generated_link_name_override and generated_name_override, by including it as a field on the passed ItemInfo parameter.

@Molot2032
Copy link
Contributor Author

Kindly requesting review @emilio @pvdrz

@emilio
Copy link
Contributor

emilio commented Jun 8, 2025

I think this is sensible, though it needs a rebase and it'd be good to document what the intended use case for having the mangling name around is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callbacks: Give ItemInfo a mangled_name field. generated_link_name_override shouldn't receive the result of generated_name_override.
2 participants