Downgrade known buggy pointer cast suggestions to MaybeIncorrect.
#15138
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @samueltardieu. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
`borrow_as_ptr` was not changed since it does try to detect temporaries and initial testing did not find obvious bugs. `ptr_cast_constness` was not changed since it isn't doing a reference-to-pointer conversion.
briansmith
force-pushed
the
b/as_ptr_maybeincorrect
branch
from
e40f37c to
590949e
Compare
|
I noticed that CI passed even though I didn't modify any tests. So I guess this means we're not testing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issues #12882 and #13910.
borrow_as_ptrwas not changed since it does try to detect temporaries and initial testing did not find obvious bugs.ptr_cast_constnesswas not changed since it isn't doing a reference-to-pointer conversion.changelog: [
cast_slice_from_raw_parts]: Disable--fixdue to known soundness issues with suggestion.changelog: [
ptr_as_ptr.rs]: Disable--fixdue to known soundness issues with suggestion.changelog: [
ptr_cast_constness]: Disable--fixdue to known soundness issues with suggestion.changelog: [
ref_as_ptr]: Disable--fixdue to known soundness issues with suggestion.