Skip to content

Do not remove as if it changes the type #15182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not remove as if it changes the type #15182

wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jun 30, 2025 •
edited by rustbot
Loading

While expr as T can be removed as a statement if expr has no side-effect, the as T part alone cannot be removed if the type of expr would be ambiguous without the cast.

changelog: [unnecessary_operation]: do not remove casts if they are useful to type the expression

Fixes #15173

@samueltardieu
Do not remove as if it changes the type
8ceb91e 
While `expr as T` can be removed as a statement if `expr` has no
side-effect, the `as T` part alone cannot be removed if the type
of `expr` would be ambiguous without the cast.
@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_operation: breaks type inference
3 participants
@samueltardieu @rustbot @Alexendoo