Skip to content

Commit 29cf892

Browse files
committed
triage: explicit ways to determine contributor activity
And advice avoid pinging inactive/on-leave contributors.
1 parent 230dda4 commit 29cf892

File tree

1 file changed

+29
-3
lines changed

1 file changed

+29
-3
lines changed

src/release/triage-procedure.md

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,30 @@ not need a review yet.)
5151

5252
### Procedure
5353

54-
We primarily triage three status labels: S-waiting-on-review,
55-
S-waiting-on-author, and (once in a while) S-blocked. Here is the procedure for
56-
each:
54+
We primarily triage Pull Requests with three status labels: `S-waiting-on-review`,
55+
`S-waiting-on-author`, and (once in a while) `S-blocked`.
56+
57+
#### Checking for contributor activeness
58+
59+
Some contributors are on leave (permanently or temporarily), and it can be quite
60+
annoying (or can make them feel pressured otherwise, even if that's not the
61+
intention of the person doing PR triaging). We should **avoid pinging contributors
62+
who are on leave or inactive**.
63+
64+
To check if a contributor is active or not, we can:
65+
66+
- Check if contributor is in alumni status. If a contributor is alumni status, they
67+
should be considered inactive. This can be checked by searching [rust-lang/team].
68+
- If the contributor is the PR reviewer, check if contributor is in [active rotation
69+
in the `[assign.adhoc_groups]` section][triagebot-toml]. Look for teams like e.g.
70+
`compiler`, `library`, `rustdoc`, `bootstrap`, etc.
71+
- Check if the contributor have any activity at all, by seeing if they participate
72+
some time recently in discussions on [Zulip](https://rust-lang.zulipchat.com/) or
73+
[rust-lang/rust].
74+
75+
If the contributor does not appear active in quite a long time based on the above
76+
avenues (say more than two months), avoid pinging the contributor, and instead
77+
only include the PR in the *Triage Report* described below.
5778

5879
#### S-waiting-on-review
5980

@@ -146,3 +167,8 @@ echo "$(date -I --date="$([ "z$(date +%a)" = "zMon" ] && echo 'today' || echo 'l
146167
Since triaging is sometimes done by looking at oldest issues first, re-applying
147168
one of the `S-*` labels will update an issue/PR's last-modified timestamp,
148169
signaling to other triagers that it has already been taken care of.
170+
171+
172+
[rust-lang/team]: https://github.com/rust-lang/team
173+
[rust-lang/rust]: https://github.com/rust-lang/rust/
174+
[triagebot-toml]: https://github.com/rust-lang/rust/blob/master/triagebot.toml

0 commit comments

Comments
 (0)