@@ -51,9 +51,33 @@ not need a review yet.)
51
51
52
52
### Procedure
53
53
54
- We primarily triage three status labels: S-waiting-on-review,
55
- S-waiting-on-author, and (once in a while) S-blocked. Here is the procedure for
56
- each:
54
+ We primarily triage Pull Requests with three status labels: ` S-waiting-on-review ` ,
55
+ ` S-waiting-on-author ` , and (once in a while) ` S-blocked ` .
56
+
57
+ #### Checking for contributor activeness
58
+
59
+ Some contributors are on leave (permanently or temporarily), and it can be quite
60
+ annoying (or can make them feel pressured otherwise, even if that's not the
61
+ intention of the person doing PR triaging). We should ** avoid pinging contributors
62
+ who are on leave or inactive** .
63
+
64
+ To check if a contributor is active or not, we can:
65
+
66
+ - Check if contributor is in alumni status. If a contributor is alumni status, they
67
+ should be considered inactive. This can be checked by searching [ rust-lang/team] .
68
+ You can use a GitHub search query like
69
+ ` repo:rust-lang/team path:/teams/ {GITHUB_HANDLE} ` (with ` GITHUB_HANDLE ` being
70
+ the contributor).
71
+ - If the contributor is the PR reviewer, check if contributor is in [ active rotation
72
+ in the ` [assign.adhoc_groups] ` section] [ triagebot-toml ] . Look for teams like e.g.
73
+ ` compiler ` , ` library ` , ` rustdoc ` , ` bootstrap ` , etc.
74
+ - Check if the contributor have any activity at all, by seeing if they participate
75
+ some time recently in discussions on [ Zulip] ( https://rust-lang.zulipchat.com/ ) or
76
+ [ rust-lang/rust] .
77
+
78
+ If the contributor does not appear active in quite a long time based on the above
79
+ avenues (say more than two months), avoid pinging the contributor, and instead
80
+ only include the PR in the * Triage Report* described below.
57
81
58
82
#### S-waiting-on-review
59
83
@@ -146,3 +170,8 @@ echo "$(date -I --date="$([ "z$(date +%a)" = "zMon" ] && echo 'today' || echo 'l
146
170
Since triaging is sometimes done by looking at oldest issues first, re-applying
147
171
one of the ` S-* ` labels will update an issue/PR's last-modified timestamp,
148
172
signaling to other triagers that it has already been taken care of.
173
+
174
+
175
+ [ rust-lang/team ] : https://github.com/rust-lang/team
176
+ [ rust-lang/rust ] : https://github.com/rust-lang/rust/
177
+ [ triagebot-toml ] : https://github.com/rust-lang/rust/blob/master/triagebot.toml
0 commit comments