-
Notifications
You must be signed in to change notification settings - Fork 192
document reqd. approvals for target changes #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fe37ec5
to
06d0525
Compare
- Demoting/removing a target | ||
- **Propose using:** MCP | ||
- **Approve using:** FCP | ||
- Write an MCP describing why the target should be demoted/removed and once discussion has | ||
concluded, an FCP can be started to approve the demotion/removal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: I believe this might be okay for tier 2/3 targets, but e.g. for i686-pc-windows-gnu (previously tier 1), demotion required full blown RFC and FCP (MCP apparently was not sufficient according to platform support docs?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, raising and lowering targets to tier 1 is an RFC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference:
- Example promote Tier 1 RFC: Promote aarch64-apple-darwin to Tier 1 rfcs#3671
- Example demote Tier 1 target RFC: RFC: Demote i686-pc-windows-gnu to Tier 2 rfcs#3771
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split this up into a tier two and tier one bullet with tier one requiring an RFC.
d17ca36
to
b358a50
Compare
cc rust-lang/rust#139451 (comment)
cc @wesleywiser
Rendered