document reqd. approvals for target changes #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jieyouxu
reviewed
Apr 16, 2025
davidtwco
force-pushed
the
new-target-approvals
branch
from
fe37ec5 to
06d0525
Compare
jieyouxu
reviewed
Apr 16, 2025
Co-authored-by: 许杰友 Jieyou Xu (Joe) <[email protected]>
tgross35
reviewed
Apr 16, 2025
jieyouxu
reviewed
May 23, 2025
Comment on lines
277
to
281
| - Demoting/removing a target | ||
| - **Propose using:** MCP | ||
| - **Approve using:** FCP | ||
| - Write an MCP describing why the target should be demoted/removed and once discussion has | ||
| concluded, an FCP can be started to approve the demotion/removal. |
There was a problem hiding this comment.
Question: I believe this might be okay for tier 2/3 targets, but e.g. for i686-pc-windows-gnu (previously tier 1), demotion required full blown RFC and FCP (MCP apparently was not sufficient according to platform support docs?)
There was a problem hiding this comment.
correct, raising and lowering targets to tier 1 is an RFC
There was a problem hiding this comment.
For reference:
- Example promote Tier 1 RFC: Promote aarch64-apple-darwin to Tier 1 rfcs#3671
- Example demote Tier 1 target RFC: RFC: Demote i686-pc-windows-gnu to Tier 2 rfcs#3771
jieyouxu
reviewed
May 24, 2025
Comment on lines
+271
to
+276
| - Renaming a target or making a breaking change to a tier two or one target | ||
| - **Propose using:** MCP | ||
| - **Approve using:** FCP | ||
| - Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP. | ||
| - If approved, the change should be accompanied by a blog post announcing the change with a | ||
| notice period of at least one release before the change applies. |
There was a problem hiding this comment.
Question: to clarify, does this mean the FCP as in @rfcbot merge by compiler-fcp or as in the Final Comment Period from a Second?
There was a problem hiding this comment.
(Meta: "FCP" being both is very confusing xD)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#139451 (comment)
cc @wesleywiser
Rendered