Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use free runners for i686-gnu jobs #133256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: use free runners for i686-gnu jobs #133256

wants to merge 1 commit into from
+77 −26

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Nov 20, 2024 •
edited
Loading

Split the i686-gnu jobs in two to move them to free runners and reduce the use of large runners in CI.

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
25f24b9 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit d7063fd with merge 25f24b9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 20, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
c1f0153 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit c50f770 with merge c1f0153...

@bors
Copy link
Contributor

bors commented Nov 20, 2024

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@MarcoIeni
Copy link
Member Author

image

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
7e36573 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 3ada89a with merge 7e36573...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 21, 2024

💔 Test failed - checks-actions

@MarcoIeni
Copy link
Member Author

image

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 535184d with merge 940450a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
940450a 
…<try>

CI: use free runners for 5 linux jobs

try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors
Copy link
Contributor

bors commented Nov 21, 2024

☀️ Try build successful - checks-actions
Build commit: 940450a (940450a274f0a885bed41898076b6a61c34ba7ad)

@MarcoIeni
Copy link
Member Author

They take too long, I'll try to split them
image

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Nov 21, 2024 •
edited
Loading

Actually the dist-arm-linux job can't be split, because it's a dist job. So I need to remove it from this PR

EDIT: x86_64-gnu-distcheck is also hard to split because it only runs one task (the distcheck)

EDIT2: fuchsia doesn't seem it can be parallelized because it's just a build

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 29, 2024

⌛ Trying commit 5722099 with merge 0021325454a312c38e992796adcf917510c10af1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
0021325 
…<try>

CI: use free runners for i686-gnu jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
MarcoIeni
MarcoIeni commented Nov 29, 2024
View reviewed changes
src/ci/docker/host-x86_64/i686-gnu-nopt/Dockerfile Outdated Show resolved Hide resolved
src/ci/docker/run.sh Show resolved Hide resolved
src/ci/github-actions/jobs.yml Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: 0021325 (0021325454a312c38e992796adcf917510c10af1)

@MarcoIeni
Copy link
Member Author

image

✨✨✨✨

@MarcoIeni MarcoIeni marked this pull request as ready for review November 29, 2024 18:15
Kobzol
Kobzol reviewed Nov 29, 2024
View reviewed changes
src/ci/github-actions/jobs.yml Outdated Show resolved Hide resolved
src/ci/docker/host-x86_64/i686-gnu-nopt/Dockerfile Outdated Show resolved Hide resolved
@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 2, 2024

⌛ Trying commit 766444e with merge c776171...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
c776171 
…<try>

CI: use free runners for i686-gnu jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@MarcoIeni
Copy link
Member Author

I removed the --skip src/* tests/* as Jakub asked. The timings looks still ok.
Now I will squash and run try again.

image

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 2, 2024

⌛ Trying commit 1ffb7be with merge d7bebc6fb7e4582344d8ba41abffc050c71a2e4e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=…
d7bebc6 
…<try>

CI: use free runners for i686-gnu jobs

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@bors
Copy link
Contributor

bors commented Dec 2, 2024

☀️ Try build successful - checks-actions
Build commit: d7bebc6 (d7bebc6fb7e4582344d8ba41abffc050c71a2e4e)

@MarcoIeni
Copy link
Member Author

I think this looks good.
image

@MarcoIeni MarcoIeni requested a review from Kobzol December 2, 2024 16:09
Kobzol
Kobzol reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit confusing that this environment variable is named SCRIPT, because that env. var. is actually used by non-Docker jobs. Normally, Docker jobs do not set this variable, as it is set inside Dockerfiles usually. The var. is read and executed by src/ci/run.sh.

I would perhaps rename the environment variable, to make it clearer that these are still Docker jobs. Maybe DOCKER_SCRIPT or something like that. Other than that LGTM.

src/ci/github-actions/jobs.yml Show resolved Hide resolved
@MarcoIeni MarcoIeni requested a review from Kobzol December 3, 2024 07:18
@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Dec 3, 2024

📌 Commit b81391e has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Awaiting requested review from Kobzol

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarcoIeni @rustbot @bors @rust-log-analyzer @Kobzol @Mark-Simulacrum