stabilize const_collections_with_hasher and build_hasher_default_const_new #133696
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Cc @rust-lang/wg-const-eval |
This comment has been minimized.
This comment has been minimized.
|
The Miri subtree was changed cc @rust-lang/miri |
RalfJung
commented
Dec 1, 2024
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
const-hashmap
branch
from
38d277e
to
92c10cf
Compare
rustbot
added
the
T-bootstrap
RalfJung
force-pushed
the
const-hashmap
branch
from
92c10cf
to
5473d63
Compare
RalfJung
force-pushed
the
const-hashmap
branch
from
5473d63
to
bf067c7
Compare
cuviper
approved these changes
Dec 3, 2024
Comment on lines
213
to
214
| /// involve a random seed, as demonstrated in the following example. **`HashMap` constructed this | ||
| /// way are not resistant against HashDoS!** |
There was a problem hiding this comment.
This should either be "HashMaps ... are not" or "A HashMap ... is not".
Comment on lines
110
to
111
| /// involve a random seed, as demonstrated in the following example. **`HashSet` constructed this | ||
| /// way are not resistant against HashDoS!** |
RalfJung
force-pushed
the
const-hashmap
branch
from
bf067c7
to
7ac7b4c
Compare
|
@bors r=cuviper rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#132612 (Gate async fn trait bound modifier on `async_trait_bounds`) - rust-lang#133545 (Lint against Symbol::intern on a string literal) - rust-lang#133558 (Structurally resolve in `probe_adt`) - rust-lang#133696 (stabilize const_collections_with_hasher and build_hasher_default_const_new) - rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint) - rust-lang#133762 (stabilize const_{size,align}_of_val) - rust-lang#133777 (document -Zrandomize-layout in the unstable book) - rust-lang#133779 (Use correct `hir_id` for array const arg infers) - rust-lang#133796 (Update the definition of `borrowing_sub`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 3, 2024
Rollup merge of rust-lang#133696 - RalfJung:const-hashmap, r=cuviper stabilize const_collections_with_hasher and build_hasher_default_const_new After a lot of preparatory work, finally we can stabilize creating `HashMap` in const context. :) FCP for const_collections_with_hasher passed in rust-lang#102575. Fixes rust-lang#102575. FCP for build_hasher_default_const_new passed in rust-lang#123197. Fixes rust-lang#123197. Cc `@Amanieu` Release notes: rust-lang#133347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of preparatory work, finally we can stabilize creating
HashMapin const context. :)FCP for const_collections_with_hasher passed in #102575.
Fixes #102575.
FCP for build_hasher_default_const_new passed in #123197.
Fixes #123197.
Cc @Amanieu
Release notes: #133347