Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for Vec::extend_from_within #133790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HypheX
Copy link
Contributor

@HypheX HypheX commented Dec 3, 2024

This closes #104762.

It rephrases some of the explanations, and greatly improves the clarity of the example.
Took some advice from the discussion here:
https://github.com/rust-lang/rust/pull/105030/files#r1059808792

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2024

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 3, 2024
@HypheX HypheX marked this pull request as ready for review December 3, 2024 08:38
@rust-log-analyzer

This comment has been minimized.

Fix missing newlines that rustfmt removed.

fix trailing whitespace

Fix duplicate word.

Reformat panic reasons into a list

remove trailing whitespace 2 electric boogaloo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing examples in Vec::extend_from_within
4 participants