-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch jemalloc-sys
back to tikv-jemalloc-sys
, and update to 0.6.0
#133792
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
switch `jemalloc-sys` back to `tikv-jemalloc-sys`, and update to 0.6.0 Some context: - we used to use jemalloc bindings from https://github.com/gnzlbg/jemallocator, since rust-lang#55238 - that crate was abandoned, picked up as a fork in https://github.com/tikv/jemallocator, so we switched to that in rust-lang#83152. - then they were able to publish to the original `jemalloc-sys` bindings crate, and `jemalloc-sys` and `tikv-jemalloc-sys` became the same thing -- so I switched back to the OG crate in rust-lang#96790 - they're now having publishing problems again: I've been waiting for tikv/jemallocator#96 for the `jemalloc-sys` 0.6.0 update for a few months, but `tikv-jemalloc-sys` is already updated to 0.6.0. A perf run showed some improvements, so this PR switches back to `tikv-jemalloc-sys` to update to 0.6.0. r? ghost
⌛ Trying commit a69fe84 with merge c4063b417f80744aa7e0f240e2c7be86d706c158... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (c4063b4): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.333s -> 766.603s (-0.10%) |
r=me |
The Miri subtree was changed cc @rust-lang/miri The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@bors r=Mark-Simulacrum |
☀️ Test successful - checks-actions |
Some context:
alloc_jemalloc
crate #55238jemalloc-sys
bindings crate, andjemalloc-sys
andtikv-jemalloc-sys
became the same thing -- so I switched back to the OG crate in Update jemalloc to v5.3 #96790jemalloc-sys
0.6.0 update for a few months, buttikv-jemalloc-sys
is already updated to 0.6.0.A perf run showed some improvements:
jemalloc
enables stats reporting by default and version 0.6.0 of the bindings now correctly enables/disables this setting when compiling the library depending on thestats
cargo feature actually being activated. So, this PR switches back totikv-jemalloc-sys
to update to 0.6.0.