Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move dist-aarch64-linux to an aarch64 runner #133809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrkajetanp
Copy link
Contributor

@mrkajetanp mrkajetanp commented Dec 3, 2024

Move the dist-aarch64-linux CI job to an aarch64 runner instead of cross-compiling it from an x86 one. This will make it possible to perform optimisations such as LTO, PGO and BOLT later on.

r? @Kobzol

try-job: dist-aarch64-linux

Move the dist-aarch64-linux CI job to an aarch64 runner instead of
cross-compiling it from an x86 one. This will make it possible to
perform optimisations such as LTO, PGO and BOLT later on.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 3, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

First let's see if it works, and what's the time impact :)

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
ci: Move dist-aarch64-linux to an aarch64 runner

Move the dist-aarch64-linux CI job to an aarch64 runner instead of cross-compiling it from an x86 one. This will make it possible to perform optimisations such as LTO, PGO and BOLT later on.

r? `@Kobzol`

try-job: dist-aarch64-linux
@bors
Copy link
Contributor

bors commented Dec 3, 2024

⌛ Trying commit 4122380 with merge 6b8022e...

@bors
Copy link
Contributor

bors commented Dec 3, 2024

☀️ Try build successful - checks-actions
Build commit: 6b8022e (6b8022ef4cbfc68ca42d9ec189f62d4c129e8685)

@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

@bors try

@bors
Copy link
Contributor

bors commented Dec 3, 2024

⌛ Trying commit 4122380 with merge 3521911...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 3, 2024
ci: Move dist-aarch64-linux to an aarch64 runner

Move the dist-aarch64-linux CI job to an aarch64 runner instead of cross-compiling it from an x86 one. This will make it possible to perform optimisations such as LTO, PGO and BOLT later on.

r? `@Kobzol`

try-job: dist-aarch64-linux
@bors
Copy link
Contributor

bors commented Dec 3, 2024

☀️ Try build successful - checks-actions
Build commit: 3521911 (352191141fb3c2d284583d558f204d3299a4f7f6)

@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

The cached duration now seems to be ~1h 20m. Before, it was approximately ~1h 50m, although on a free runner.

@mrkajetanp
Copy link
Contributor Author

Before meaning when it was running on the x86 runner? That would make sense given that it had to build the whole cross-compiling toolchain first I suppose.

@Kobzol
Copy link
Contributor

Kobzol commented Dec 3, 2024

Yeah, before meaning when it was cross-compiling, and also running on a 4-core machine (vs now running on a 8-core machine). The costs of the ARM machine is quite different to us than the previous machine though, so we'll need to discuss this in the infra team.

@mrkajetanp
Copy link
Contributor Author

Fair enough, best of luck! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants