Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff
can both lint and format Python code (in fact, it should be a mostly drop-in replacement forblack
in terms of formatting), so it's not needed to useblack
anymore. This PR removesblack
and replaces it withruff
, to get rid of one Python dependency, and also to make Python formatting faster (although that's a small thing).If we decide to merge this, we'll need to "reformat the world" -
ruff
is not perfectly compatible withblack
, and it also looks likeblack
was actually ignoring some files before. I tried it locally (./x test tidy --extra-checks=py:fmt --bless
) and it also reformatted some code in subtrees (e.g.clippy
orrustc_codegen_gcc
) - I'm not sure how to handle that.