Replace evaluated cfg_attr in AST with a placeholder attribute for accurate span tracking
#133823
+327
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
…pan tracking Previously, when evaluating a `#[cfg_attr(..)]` to false, the entire attribute was removed from the AST. Afterwards, we insert in its place a `#[rustc-cfg-placeholder]` attribute so that checks for attributes can still know about their placement. This is particularly relevant when we suggest removing items with `cfg_attr`s (fix rust-lang#56328). We use `rustc-cfg-placeholder` as it is an ident that can't be written by the end user to begin with. We tweak the wording of the existing "unused `extern crate`" lint. ``` warning: unused `extern crate` --> $DIR/removing-extern-crate.rs:9:1 | LL | extern crate removing_extern_crate as foo; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unused | note: the lint level is defined here --> $DIR/removing-extern-crate.rs:6:9 | LL | #![warn(rust_2018_idioms)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(unused_extern_crates)]` implied by `#[warn(rust_2018_idioms)]` help: remove the unused `extern crate` | LL - #[cfg_attr(test, macro_use)] LL - extern crate removing_extern_crate as foo; LL + | ```
estebank
commented
Dec 3, 2024
| help: remove the unused `extern crate` | ||
| | | ||
| LL - extern crate core; | ||
| LL + |
There was a problem hiding this comment.
I thought this was a rendering bug, but it is because of the //~ removed comment.
This comment has been minimized.
This comment has been minimized.
estebank
changed the title
cfg_attr in AST with a placeholder attribute for accurate span trackingcfg_attr in AST with a placeholder attribute for accurate span tracking
Avoid "duplicated attribute" lints firing on the cfg placeholder.
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when evaluating a
#[cfg_attr(..)]to false, the entire attribute was removed from the AST. Afterwards, we insert in its place a#[rustc-cfg-placeholder]attribute so that checks for attributes can still know about their placement. This is particularly relevant when we suggest removing items withcfg_attrs (fix #56328). We userustc-cfg-placeholderas it is an ident that can't be written by the end user to begin with. We tweak the wording of the existing "unusedextern crate" lint.r? @petrochenkov