Skip to content

Implement use associated items of traits #134754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

Implement use associated items of traits #134754

merged 1 commit into from
Jan 17, 2025

Conversation

frank-king
Copy link
Contributor

This PR implements #134691.

@rustbot
Copy link
Collaborator

rustbot commented Dec 25, 2024

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu
Copy link
Member

cc @petrochenkov as this PR has some non-trivial resolve changes.

@frank-king frank-king force-pushed the feature/import_trait_associated_functions branch from dc2bdee to 6905a19 Compare December 25, 2024 08:20
@petrochenkov petrochenkov self-assigned this Dec 25, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@frank-king frank-king force-pushed the feature/import_trait_associated_functions branch 2 times, most recently from 8606eb3 to 72bc889 Compare December 25, 2024 15:16
@frank-king frank-king force-pushed the feature/import_trait_associated_functions branch 2 times, most recently from d79e0e1 to 2427364 Compare January 15, 2025 14:51
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2025
@frank-king frank-king force-pushed the feature/import_trait_associated_functions branch from 39b3949 to e249e6c Compare January 16, 2025 08:32
@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

The Miri subtree was changed

cc @rust-lang/miri

@frank-king frank-king force-pushed the feature/import_trait_associated_functions branch from e249e6c to 5079acc Compare January 16, 2025 08:34
@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 16, 2025

📌 Commit 5079acc has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2025
@matthiaskrgr
Rollup merge of rust-lang#134754 - frank-king:feature/import_trait_as…
7dce295 
…sociated_functions, r=oli-obk

Implement `use` associated items of traits

This PR implements rust-lang#134691.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@bors
Auto merge of rust-lang#135576 - matthiaskrgr:rollup-e38vft0, r=matth…
83f6d74 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#133720 ([cfg_match] Adjust syntax)
 - rust-lang#134496 (Update documentation for Arc::from_raw, Arc::increment_strong_count, and Arc::decrement_strong_count to clarify allocator requirement)
 - rust-lang#134754 (Implement `use` associated items of traits)
 - rust-lang#135249 (Fix overflows in the implementation of `overflowing_literals` lint's help)
 - rust-lang#135251 (Only treat plain literal patterns as short)
 - rust-lang#135556 (Clarify note in `std::sync::LazyLock` example)
 - rust-lang#135560 (Update `compiler-builtins` to 0.1.144)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r- #135576 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2025
@fmease
Copy link
Member

fmease commented Jan 16, 2025

Hmm, I'm pretty sure that failure is due to #135560 instead.

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jan 16, 2025

📌 Commit 5079acc has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2025
@bors
Auto merge of rust-lang#135592 - matthiaskrgr:rollup-4t69l7i, r=matth…
76a030a 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#134754 (Implement `use` associated items of traits)
 - rust-lang#135481 (coverage: Completely overhaul counter assignment, using node-flow graphs)
 - rust-lang#135504 (Allow coercing safe-to-call target_feature functions to safe fn pointers)
 - rust-lang#135561 (Update docs for `-Clink-dead-code` to discourage its use)
 - rust-lang#135574 (ci: mirror ubuntu:22.04 to ghcr.io)
 - rust-lang#135585 (resolve symlinks of LLVM tool binaries before copying them)
 - rust-lang#135588 (Add license-metadata.json to rustc-src tarball.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62d0f45 into rust-lang:master Jan 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2025
@rust-timer
Unrolled build for rust-lang#134754
5d62e18 
Rollup merge of rust-lang#134754 - frank-king:feature/import_trait_associated_functions, r=oli-obk

Implement `use` associated items of traits

This PR implements rust-lang#134691.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2025
Closed
This was referenced Mar 19, 2025
Closed
Merged
@mejrs mejrs mentioned this pull request Mar 30, 2025
Merged
@cramertj cramertj mentioned this pull request Apr 1, 2025
Open
4 tasks
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 3, 2025
@m-ou-se
Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss
2f34cdd 
unstable book: document import_trait_associated_functions

Documents rust-lang#134691 which was implemented in rust-lang#134754
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss
ee56188 
unstable book: document import_trait_associated_functions

Documents rust-lang#134691 which was implemented in rust-lang#134754
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2025
@rust-timer
Unrolled build for rust-lang#139149
0c50312 
Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss

unstable book: document import_trait_associated_functions

Documents rust-lang#134691 which was implemented in rust-lang#134754
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 3, 2025
@matthiaskrgr
Rollup merge of rust-lang#138712 - petrochenkov:impasst, r=fmease
a1a23de 
resolve: Support imports of associated types and glob imports from traits

Follow up to rust-lang#134754, part of rust-lang#134691.
This PR also closes rust-lang#138711 now.

Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable.
It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there.

And since we can import associated trait items now, glob imports from traits can also be allowed.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2025
@rust-timer
Unrolled build for rust-lang#138712
8b545ce 
Rollup merge of rust-lang#138712 - petrochenkov:impasst, r=fmease

resolve: Support imports of associated types and glob imports from traits

Follow up to rust-lang#134754, part of rust-lang#134691.
This PR also closes rust-lang#138711 now.

Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable.
It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there.

And since we can import associated trait items now, glob imports from traits can also be allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease left review comments

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
9 participants
@frank-king @rustbot @rust-log-analyzer @jieyouxu @oli-obk @bors @matthiaskrgr @fmease @petrochenkov