Clean the LLVM wrapper #135502
Clean the LLVM wrapper #135502
Conversation
rustbot
added
S-waiting-on-review
| pub enum UnnamedAddr { | ||
| No, | ||
| Local, | ||
| Global, |
There was a problem hiding this comment.
For enums that are passed across FFI to C/C++ code, we shouldn't delete Rust-side variants that are unused.
Doing so just makes it harder to verify that the Rust-side enum and the C-side enum have the same layout, which is essential for soundness.
| Default, | ||
| Gnu, |
There was a problem hiding this comment.
This is another case where removing unused enum variants is a net negative. It just makes auditing harder.
There was a problem hiding this comment.
In this case, it was removed from both the Rust and C++ side: would you rather that I add it back to both?
There was a problem hiding this comment.
Yeah, please add it back to both.
(Our LLVMRustDebugNameTableKind enum is basically just a substitute for LLVM's DICompileUnit::DebugNameTableKind. It's needed to work around the fact that we can't reliably pass LLVM's C++ enums across FFI, because the LLVM C++ API isn't stable, so upgrading LLVM would potentially introduce silent UB if the enums change incompatibly.)
|
(There's more review I want to do here, but unfortunately GitHub has decided that trying to add a review comment should now hang the browser for several seconds, so the review interface is more-or-less unusable right now.) |
|
I've tried some of this cleanup in #127274, so some review comments from it can be used here as well. |
Good call:
|
|
Yes, removing the tail call stuff is fine, as you said it is a trivial revert. |
|
r? @Zalathar as you're already reviewing this PR 🤔 feel free to reassign |
|
☔ The latest upstream changes (presumably #135335) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm in favour of removing unnecessary I would suggest trying to split it up into smaller self-contained PRs, e.g.:
(I would also be perfectly happy to write some of these PRs myself, but if you are keen to write them then I can review them myself without having to rely on another reviewer, so either approach is fine with me.) |
Fair enough: I've converted this to a draft and will send out sliced up PRs as I have time |
|
First chunk, remove the dead code: #136653 |
Remove dead code from rustc_codegen_llvm and the LLVM wrapper First step to clean up the LLVM wrapper: remove existing dead code. Split out of rust-lang#135502 r? `@Zalathar`
Remove dead code from rustc_codegen_llvm and the LLVM wrapper First step to clean up the LLVM wrapper: remove existing dead code. Split out of rust-lang#135502 r? ``@Zalathar``
Rollup merge of rust-lang#136653 - dpaoliello:cleanllvm1, r=Zalathar Remove dead code from rustc_codegen_llvm and the LLVM wrapper First step to clean up the LLVM wrapper: remove existing dead code. Split out of rust-lang#135502 r? ``@Zalathar``
|
☔ The latest upstream changes (presumably #136697) made this pull request unmergeable. Please resolve the merge conflicts. |
cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
Rollup merge of rust-lang#136721 - dpaoliello:cleanllvm2, r=Zalathar cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
dpaoliello
force-pushed
the
cleanllvm
branch
from
80f9eb9 to
8aff664
Compare
|
Closing since we're doing this in pieces instead. |
cg_llvm: Reduce visibility of all functions in the llvm module Next part of rust-lang#135502 This reduces the visibility of all functions in the `llvm` module to `pub(crate)` and marks the `enzyme_ffi` modules with `#![expect(dead_code)]` (as previously discussed: <rust-lang#135502 (comment)>). r? `@Zalathar`
cg_llvm: Reduce visibility of all functions in the llvm module Next part of rust-lang#135502 This reduces the visibility of all functions in the `llvm` module to `pub(crate)` and marks the `enzyme_ffi` modules with `#![expect(dead_code)]` (as previously discussed: <rust-lang#135502 (comment)>). r? ``@Zalathar``
Rollup merge of rust-lang#136881 - dpaoliello:cleanllvm3, r=Zalathar cg_llvm: Reduce visibility of all functions in the llvm module Next part of rust-lang#135502 This reduces the visibility of all functions in the `llvm` module to `pub(crate)` and marks the `enzyme_ffi` modules with `#![expect(dead_code)]` (as previously discussed: <rust-lang#135502 (comment)>). r? ``@Zalathar``
…bilee [cg_llvm] Remove dead error message Part of rust-lang#135502 Discovered a dead error message in rustc_codegen_llvm, so removing it. r? `@Zalathar`
…bilee [cg_llvm] Remove dead error message Part of rust-lang#135502 Discovered a dead error message in rustc_codegen_llvm, so removing it. r? ``@Zalathar``
Rollup merge of rust-lang#136993 - dpaoliello:cleanllvm4, r=workingjubilee [cg_llvm] Remove dead error message Part of rust-lang#135502 Discovered a dead error message in rustc_codegen_llvm, so removing it. r? ``@Zalathar``
cg_llvm: Reduce visibility of all functions in the llvm module Next part of #135502 This reduces the visibility of all functions in the `llvm` module to `pub(crate)` and marks the `enzyme_ffi` modules with `#![expect(dead_code)]` (as previously discussed: <rust-lang/rust#135502 (comment)>). r? ``@Zalathar``
This change sets the visibility for LLVM wrapper FFI items to
pub(crate), which allows Rust's dead code lints to flag unused parts of the LLVM wrapper.