-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Do install msys2 in CI #136810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Do install msys2 in CI #136810
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,9 @@ jobs: | |
name: ${{ matrix.full_name }} | ||
needs: [ calculate_matrix ] | ||
runs-on: "${{ matrix.os }}" | ||
defaults: | ||
run: | ||
shell: ${{ contains(matrix.os, 'windows') && 'msys2 {0}' || 'bash' }} | ||
timeout-minutes: 360 | ||
env: | ||
CI_JOB_NAME: ${{ matrix.name }} | ||
|
@@ -77,6 +80,26 @@ jobs: | |
# Check the `calculate_matrix` job to see how is the matrix defined. | ||
include: ${{ fromJSON(needs.calculate_matrix.outputs.jobs) }} | ||
steps: | ||
- if: contains(matrix.os, 'windows') | ||
uses: msys2/[email protected] | ||
with: | ||
# FIXME(#136795): this mingw installation seems to be needed for | ||
# `i686-pc-windows-gnu`, otherwise we somehow incorrectly ship the | ||
# 64-bit `libwinpthread-1.dll` and then `rustc` explodes. | ||
# | ||
# i686 jobs use mingw32. x86_64 and cross-compile jobs use mingw64. | ||
msystem: ${{ contains(matrix.name, 'i686') && 'mingw32' || 'mingw64' }} | ||
# don't try to download updates for already installed packages | ||
update: false | ||
# don't try to use the msys that comes built-in to the github runner, | ||
# so we can control what is installed (i.e. not python) | ||
release: true | ||
# Inherit the full path from the Windows environment, with MSYS2's */bin/ | ||
# dirs placed in front. This lets us run Windows-native Python etc. | ||
path-type: inherit | ||
install: > | ||
make | ||
|
||
- name: disable git crlf conversion | ||
run: git config --global core.autocrlf false | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.