-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build GCC on CI #136921
base: master
Are you sure you want to change the base?
Build GCC on CI #136921
Conversation
|
This comment has been minimized.
This comment has been minimized.
I think we really should break it out to a separate step |
Move `llvm.ccache` to `build.ccache` (S)ccache can be useful for more things that just LLVM. For example, we will soon want to use it also for GCC, and theoretically also for building stage0 Rust tools (rust-lang#136921, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Using.20sccache.20for.20Rust). r? `@onur-ozkan`
Move `llvm.ccache` to `build.ccache` (S)ccache can be useful for more things that just LLVM. For example, we will soon want to use it also for GCC, and theoretically also for building stage0 Rust tools (rust-lang#136921, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Using.20sccache.20for.20Rust). r? ``@onur-ozkan``
Rollup merge of rust-lang#136941 - Kobzol:ccache-build, r=onur-ozkan Move `llvm.ccache` to `build.ccache` (S)ccache can be useful for more things that just LLVM. For example, we will soon want to use it also for GCC, and theoretically also for building stage0 Rust tools (rust-lang#136921, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Using.20sccache.20for.20Rust). r? ``@onur-ozkan``
☔ The latest upstream changes (presumably #137001) made this pull request unmergeable. Please resolve the merge conflicts. |
It is apparently required to download GCC dependencies.
The job Click to see the possible cause of the failure (guessed by this bot)
|
Previously, we have downloaded a specific commit of GCC and prebuilt it inside Docker using the
build-gccjit.sh
script. This PR removes that scripts and uses the bootstrap GCC step. This allows us to use thesrc/gcc
submodule for determining which GCC should be built, and it also moves the logic closer to LLVM, which is also built by bootstrap.A few things to note:
sccache
option is currently in thellvm
block, so the GCC build usesllvm.ccache
, which is a bit weird :) We could either addgcc.ccache
, or (what I think would be better) to just moveccache
to thebuild
section, as I don't think that it will be necessary to use ccache for LLVM, but not for GCC.r? @onur-ozkan