Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_target: Sync with stdarch (important parts) #138820

Closed

Conversation

a4lg
Copy link

@a4lg a4lg commented Mar 22, 2025

Of RISC-V features defined in stdarch, this commit adds ratified extensions satisfying following criteria:

  • Formerly a part of the I extension and splitted thereafter (now ratified as I + Zifencei + Zicsr + Zicntr + Zihpm) or
  • Dicoverable from newer versions of the Linux kernel (Ztso and Zihintpause).

This is based on the latest ratified ISA Manuals (version 20240411).

LLVM Definitions:

One of those, Zicsr, is a dependency of many other ISA extensions and this commit adds correct dependencies to Zicsr except V (due to ongoing PR #138742).


Related:

NOT Related but linked:

@rustbot label +T-compiler +O-riscv +A-target-feature

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-riscv Target: RISC-V architecture labels Mar 22, 2025
@a4lg a4lg force-pushed the riscv-feature-addition-base-i-and-ztso branch 2 times, most recently from e7f364c to 4a8cb94 Compare March 22, 2025 03:50
@a4lg
Copy link
Author

a4lg commented Mar 22, 2025

@rustbot r? @Amanieu

@rust-log-analyzer

This comment has been minimized.

@a4lg
Copy link
Author

a4lg commented Mar 22, 2025

Hmm, considering the minimum LLVM version, I have to remove Ztso for now (LLVM 19 stabilized support for Ztso).

Of RISC-V features defined in stdarch, this commit adds extensions
satisfying following criteria:

*   Formerly a part of the "I" extension and splitted thereafter
    (now ratified as "I" + "Zifencei" + "Zicsr" + "Zicntr" + "Zihpm") or
*   Dicoverable from newer versions of the Linux kernel ("Zihintpause").

This is based on the latest ratified ISA Manuals (version 20240411).

One of those, "Zicsr", is a dependency of many other ISA extensions and
this commit adds correct dependencies to "Zicsr" except "V"
(due to an ongoing PR).
@a4lg a4lg force-pushed the riscv-feature-addition-base-i-and-ztso branch from 4a8cb94 to 1649e52 Compare March 22, 2025 04:38
@a4lg a4lg closed this Mar 22, 2025
@a4lg a4lg deleted the riscv-feature-addition-base-i-and-ztso branch March 22, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. O-riscv Target: RISC-V architecture S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants