Add FromIterator impls for ascii::Chars to Strings
#141445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
yotamofek
force-pushed
the
pr/library/from-iter-char-string
branch
from
4e9a021 to
8365332
Compare
joboet
reviewed
May 23, 2025
library/alloc/src/string.rs
Outdated
Comment on lines
2380
to
2382
| let mut buf = String::new(); | ||
| buf.extend(iter); | ||
| buf |
There was a problem hiding this comment.
Something along the lines of
Suggested change
| let mut buf = String::new(); | |
| buf.extend(iter); | |
| buf | |
| let mut buf = iter.into_iter().map(Char::to_u8).collect(); | |
| unsafe { String::from_utf8_unchecked(buf) } |
There was a problem hiding this comment.
Huh, that's clever, thanks!
library/alloc/src/string.rs
Outdated
Comment on lines
2390
to
2392
| let mut buf = String::new(); | ||
| buf.extend(iter); | ||
| buf |
rustbot
added
the
T-libs-api
yotamofek
force-pushed
the
pr/library/from-iter-char-string
branch
from
8365332 to
8569bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to
collectascii chars into aStringwhile working on #141369 , and was surprised these impls don't exist. Seems to me to be simply oversight.BTW, I only added
impl FromIterator<ascii::Char> for Cow<'_, str>, without a correspondingFromIterator<&Char>impl, because there's no existing impl forFromIterator<&char>, but that might be oversight too.cc #110998