Rollup of 7 pull requests #141484
Merged
Rollup of 7 pull requests #141484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slight grammar changes for clarity
… r=ChrisDenton GetUserProfileDirectoryW is now documented to always store the size Update to match MicrosoftDocs/sdk-api#1810 Also fix a bug in the Miri implementation while I am starting at that code... r? ```@ChrisDenton``` Fixes rust-lang#141254
Disable `triagebot`'s `glacier` handler Part of rust-lang#125459. Unblocks rust-lang/triagebot#2008. r? Urgau
…structural-match, r=spastorino Dont walk into unsafe binders when emiting error for non-structural type match Fixes rust-lang#141422. The other two binder-having types are also special cased here, unsurprisingly. r? oli-obk
…l, r=lcnr Do not try to confirm non-dyn compatible method See the comment I left in `compiler/rustc_hir_typeck/src/method/confirm.rs`. If we have a receiver that does not deref to the `dyn Trait` we're assembling the method from, then we used to ICE, but that's something that is possible to encounter with arbitrary self types. r? oli-obk Fixes rust-lang#141419
Improve CONTRIBUTING.md grammar and clarity slight grammar changes for clarity
Add 2nd Solaris target maintainer Based on concenr here rust-lang/compiler-team#870 (comment) I propose my coleague ```@kulikjak``` as 2nd Solaris maintainer. He already did some work to Rust in past.
…eyouxu
Suggest correct `version("..")` predicate syntax in check-cfg
This PR specialize the `unexpected_cfgs` lint diagnostic to suggest correct `version("..")` predicate syntax when providing the key-value one, eg. `version = "1.27"`.
Fixes rust-lang#141440
r? ``@jieyouxu``
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 5af801b687 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5af801b (parent) -> 3de4f1c (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3de4f1ccf3873782fae2a3883d029ed3d4542581 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (3de4f1c): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -4.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -6.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 776.203s -> 777.23s (0.13%) |
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 26, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#141405 (GetUserProfileDirectoryW is now documented to always store the size) - rust-lang#141427 (Disable `triagebot`'s `glacier` handler) - rust-lang#141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - rust-lang#141438 (Do not try to confirm non-dyn compatible method) - rust-lang#141444 (Improve CONTRIBUTING.md grammar and clarity) - rust-lang#141446 (Add 2nd Solaris target maintainer) - rust-lang#141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
triagebot'sglacierhandler #141427 (Disabletriagebot'sglacierhandler)version("..")predicate syntax in check-cfg #141456 (Suggest correctversion("..")predicate syntax in check-cfg)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup