Rollup of 6 pull requests #141906

chenyukang · 2025-06-02T12:57:45Z

Successful merges:

allow macro_use as first segment #141884 (allow macro_use as first segment)
[RTE-484] Update SGX maintainers #141885 ([RTE-484] Update SGX maintainers)
Fix false positive lint error from no_implicit_prelude attr #141892 (Fix false positive lint error from no_implicit_prelude attr)
rustc-dev-guide subtree update #141894 (rustc-dev-guide subtree update)
tshepang has a new email #141895 (tshepang has a new email)
Fix citool tests when executed locally #141897 (Fix citool tests when executed locally)

r? @ghost
@rustbot modify labels: rollup

Normally I refrain from nit picking, but this seamed worth it.

Small typo and style fixes in binders.md

The order might have been reversed at some point, leading to the two chapters talking about each other in the wrong order.

Fix misdirected link for `TypingEnv`

Update links between ty-module and binders

Make it clear we talk about early bound params

It does not do any line matching, so it should be separated from the other types.

Now that CI has been finally migrated to `rust-lang/rust`.

document why rustdoc cannot look at function bodies

rustdoc.md: reorder list so test suites are not split up

typo

…-lang-ci Remove mentions of rust-lang-ci/rust

Update `rustc_on_unimplemented` docs

…s-yes Flesh out sections about crashes tests and update mentions of glacier

Link normalization chapter

Add time reference and tracking info for trait system refactor

This effort is blocked, so pointing new contributors here would be setting them up for failure. https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/about.3A.20status.20of.20askama.20migration/with/497389045

Add opaque type attributes

Fix link to GatherBorrows

They couldn't be executed locally before due to some additional environment reads.

allow macro_use as first segment Fixes rust-lang#140255 This issue may raise a question: It's reasonable an external crate name or import target be legally named `macro_use`?

…sgx_maintainers, r=Noratrieb [RTE-484] Update SGX maintainers `@mzohreva` is no longer with Fortanix. We need to change the SGX maintainers accordingly.

…n-crate, r=petrochenkov Fix false positive lint error from no_implicit_prelude attr Fixes rust-lang#141785 r? `@petrochenkov`

rustc-dev-guide subtree update r? `@ghost`

tshepang has a new email

Fix citool tests when executed locally They couldn't be executed locally before due to some additional environment reads. I also investigated the annoying rebuilds that we see on CI all the time, and they are caused by `ring`'s build script. It should be fixed in the next ring release (briansmith/ring#2525), so we can just wait for that and then update `ring`. r? `@marcoieni`

chenyukang · 2025-06-02T12:58:11Z

@bors r+ rollup=never p=5

bors · 2025-06-02T12:58:14Z

📌 Commit 8f240de has been approved by chenyukang

It is now in the queue for this repository.

bors · 2025-06-02T16:15:33Z

⌛ Testing commit 8f240de with merge 449c801...

bors · 2025-06-02T19:34:32Z

☀️ Test successful - checks-actions
Approved by: chenyukang
Pushing 449c801 to master...

rust-timer · 2025-06-02T19:36:18Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141884	allow macro_use as first segment	`a2ba15570f6c006e3f351e5b8650869900700421` (link)
#141885	[RTE-484] Update SGX maintainers	`a5550242e35b88cf15a63359aaed9030270d5a7e` (link)
#141892	Fix false positive lint error from no_implicit_prelude attr	`762ae24f3e6d096e3a2202ccaa853897f2794619` (link)
#141894	rustc-dev-guide subtree update	`e28b80446d7399e23da543309cf2ca87b656d664` (link)
#141895	tshepang has a new email	`173419a780ce13ecb9dcbe73cd21bfd341db71a5` (link)
#141897	Fix citool tests when executed locally	`3b3002bc79935baf6e335662961b3d0b2cfba196` (link)

previous master: 2398bd60ef

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-02T19:37:28Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2398bd6 (parent) -> 449c801 (this PR)

Test differences

Show 8 test diffs

Stage 1

[crashes] tests/crashes/140255.rs: pass -> [missing] (J2)
[ui] tests/ui/attributes/illegal-macro-use.rs: [missing] -> pass (J2)
[ui] tests/ui/attributes/use-extern-crate-named-macro-use.rs: [missing] -> pass (J2)
[ui] tests/ui/resolve/extern-crate-lint-issue-141785.rs: [missing] -> pass (J2)

Stage 2

[crashes] tests/crashes/140255.rs: pass -> [missing] (J0)
[ui] tests/ui/attributes/illegal-macro-use.rs: [missing] -> pass (J1)
[ui] tests/ui/attributes/use-extern-crate-named-macro-use.rs: [missing] -> pass (J1)
[ui] tests/ui/resolve/extern-crate-lint-issue-141785.rs: [missing] -> pass (J1)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 449c801783ecef2aad3ae03d6c9e4ac007de7d4b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 4565.1s -> 6204.1s (35.9%)
dist-x86_64-apple: 9662.7s -> 11264.8s (16.6%)
x86_64-apple-1: 9426.5s -> 10879.8s (15.4%)
dist-apple-various: 7420.4s -> 6713.7s (-9.5%)
dist-aarch64-apple: 6000.7s -> 6546.8s (9.1%)
x86_64-msvc-2: 6951.5s -> 6430.5s (-7.5%)
x86_64-gnu-aux: 5483.7s -> 5811.9s (6.0%)
aarch64-apple: 5717.3s -> 5416.7s (-5.3%)
aarch64-gnu: 6516.6s -> 6856.9s (5.2%)
x86_64-msvc-ext1: 7114.5s -> 6787.0s (-4.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-03T08:07:23Z

Finished benchmarking commit (449c801): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.8%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	0.6%	[0.4%, 0.7%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-2.1%, -0.4%]	11
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Cycles

Results (secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.4%, 0.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-3.6%, -0.5%]	7
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 743.192s -> 744.828s (0.22%)
Artifact size: 372.27 MiB -> 372.28 MiB (0.00%)

Lysxia and others added 30 commits May 14, 2025 11:36

Fix link to GatherBorrows

66b2bf1

Small typo and style fixes in binders.md

0653799

Normally I refrain from nit picking, but this seamed worth it.

Merge pull request rust-lang#2396 from smanilov/patch-11

33aa48c

Small typo and style fixes in binders.md

Update links between ty-module and binders

2754f18

The order might have been reversed at some point, leading to the two chapters talking about each other in the wrong order.

Fix misdirected link for TypingEnv

a611f50

Merge pull request rust-lang#2399 from steffahn/fix-tenv-link

1944bce

Fix misdirected link for `TypingEnv`

Make it clear we talk about early bound params

50211e0

Merge pull request rust-lang#2398 from smanilov/patch-12

1710217

Update links between ty-module and binders

Merge pull request rust-lang#2400 from smanilov/patch-13

f499cd0

Make it clear we talk about early bound params

~? annotation type is special

bf90c3e

It does not do any line matching, so it should be separated from the other types.

rustdoc.md: reorder list so test suites are not split up

3441154

Remove mentions of rust-lang-ci/rust

346ef86

Now that CI has been finally migrated to `rust-lang/rust`.

Merge pull request rust-lang#2403 from rust-lang/tshepang-patch-1

55df9f4

document why rustdoc cannot look at function bodies

589d03c

Merge pull request rust-lang#2406 from jyn514/rustdoc-bodies

419ba5d

document why rustdoc cannot look at function bodies

Merge pull request rust-lang#2404 from lolbinarycat/patch-1

6232b33

rustdoc.md: reorder list so test suites are not split up

Add LLVM link in appendix

8e91013

Merge pull request rust-lang#2408 from chenyukang/yukang-add-llvm-link

3668fcf

typo

9dd67e1

Merge pull request rust-lang#2410 from rust-lang/tshepang-patch-1

8b6010a

typo

Merge pull request rust-lang#2405 from Kobzol/remove-mentions-of-rust…

4831646

…-lang-ci Remove mentions of rust-lang-ci/rust

Update rustc_on_unimplemented docs

d0582aa

Merge pull request rust-lang#2357 from mejrs/diag

a34ef82

Update `rustc_on_unimplemented` docs

Flesh out sections about crashes tests and update mentions of glacier

8d1337b

Merge pull request rust-lang#2413 from fmease/glacier-no-crashes-test…

d5b3f8d

…s-yes Flesh out sections about crashes tests and update mentions of glacier

Link normalization chapter

b73dfdf

Add time reference and tracking info for trait system refactor

740aaf7

Merge pull request rust-lang#2414 from smanilov/patch-15

8b4f9b6

Link normalization chapter

Merge pull request rust-lang#2407 from smanilov/patch-14

db99821

Add time reference and tracking info for trait system refactor

Remove rustdoc askama migration from getting started

04f466a

This effort is blocked, so pointing new contributors here would be setting them up for failure. https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/about.3A.20status.20of.20askama.20migration/with/497389045

tshepang and others added 10 commits June 2, 2025 11:55

Merge pull request rust-lang#2435 from smanilov/patch-19

0e379a6

Add opaque type attributes

Merge pull request rust-lang#2386 from Lysxia/fix-link

c197636

Fix link to GatherBorrows

tshepang has a new email

69e3583

Fix citool tests when executed ocally

28cf702

They couldn't be executed locally before due to some additional environment reads.

Rollup merge of rust-lang#141884 - bvanjoi:issue-140255, r=petrochenkov

8d9fc03

allow macro_use as first segment Fixes rust-lang#140255 This issue may raise a question: It's reasonable an external crate name or import target be legally named `macro_use`?

Rollup merge of rust-lang#141885 - raoulstrackx:raoul/rte-484-update_…

05ee4a3

…sgx_maintainers, r=Noratrieb [RTE-484] Update SGX maintainers `@mzohreva` is no longer with Fortanix. We need to change the SGX maintainers accordingly.

Rollup merge of rust-lang#141892 - chenyukang:yukang-fix-141785-exter…

1931272

…n-crate, r=petrochenkov Fix false positive lint error from no_implicit_prelude attr Fixes rust-lang#141785 r? `@petrochenkov`

Rollup merge of rust-lang#141894 - tshepang:rdg-push, r=jieyouxu

a501cc7

rustc-dev-guide subtree update r? `@ghost`

Rollup merge of rust-lang#141895 - tshepang:new-address, r=jieyouxu

ad00cbe

tshepang has a new email

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2025

bors merged commit 449c801 into rust-lang:master Jun 2, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #141906

Rollup of 6 pull requests #141906

Uh oh!

chenyukang commented Jun 2, 2025 •

edited by rustbot

Loading

Uh oh!

chenyukang commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 3, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #141906

Rollup of 6 pull requests #141906

Uh oh!

Conversation

chenyukang commented Jun 2, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chenyukang commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

bors commented Jun 2, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 2, 2025

Uh oh!

github-actions bot commented Jun 2, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 3, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

chenyukang commented Jun 2, 2025 •

edited by rustbot

Loading