-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add modern AVR mcus like avr128db28 and attiny3224 #142454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Failed to set assignee to
|
These commits modify compiler targets. |
Looks good to me - we should wait for LLVM, though. |
We need to wait for the LLVM change to make it into our LLVM right? Or, what is the behavior when these are used but LLVM doesn't yet support them? @rustbot blocked |
"avr64da28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64da32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64da48" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64da64" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64db28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64db32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64db48" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64db64" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64dd14" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64dd20" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64dd28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64dd32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64du28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64du32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64ea28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64ea32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64ea48" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64sd28" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64sd32" => elf::EF_AVR_ARCH_XMEGA2, | ||
"avr64sd48" => elf::EF_AVR_ARCH_XMEGA2, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small style q, should this block be sorted in with avr16/avr32/avr128?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small style q, should this block be sorted in with avr16/avr32/avr128?
It is now in sync with the LLVM source order, so I prefer to not diverge from that.
@tgross35 The users get a:
So there is no critical reason to wait, but waiting would allow easy and better testing of this PR, so I suggest to wait until the LLVM is in our LLVM. |
Related to llvm/llvm-project#143914
r? @Patryk27