collect delayed lints in hir_crate_items

[jdonszelmann]

r? @oli-obk

Attempt to mitigate perf problems in #138164

[jdonszelmann]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 6f5a717 with merge 437cd00...

[bors]

☀️ Try build successful - checks-actions
Build commit: 437cd00 (437cd0066d76142190dee1c502aa6e12d2212196)

[rust-timer]

Finished benchmarking commit (437cd00): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.1%]	101
Improvements ✅ (secondary)	-0.8%	[-2.5%, -0.2%]	53
All ❌✅ (primary)	-0.4%	[-0.8%, -0.1%]	101

Max RSS (memory usage)

Results (primary -2.6%, secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.6%, 2.9%]	2
Improvements ✅ (primary)	-2.6%	[-6.6%, -0.8%]	4
Improvements ✅ (secondary)	-6.2%	[-11.5%, -1.8%]	5
All ❌✅ (primary)	-2.6%	[-6.6%, -0.8%]	4

Cycles

Results (primary -1.4%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.1%, 2.3%]	2
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-2.7%	[-3.5%, -1.4%]	9
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.993s -> 757.521s (0.33%)
Artifact size: 372.27 MiB -> 372.22 MiB (-0.01%)

[jdonszelmann]

Well, it looks like that helps a bit

[oli-obk]

@bors r+

[bors]

📌 Commit 6f5a717 has been approved by oli-obk

It is now in the queue for this repository.

[jdonszelmann]

Not quite sure it's all of it but it seems like a good change @oli?

[jdonszelmann]

Ah, already r plussed ,Ty :3

[jdonszelmann]

oh sorry oli, meant to ping the other one hehe