Rollup of 14 pull requests #142644
Merged
Rollup of 14 pull requests #142644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is one-time initialization data, it can just be a function parameter. we also move the json parsing into createSrcSidebar to save a few bytes.
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
This allows a more gradual transition path for projects that need to use use the spec-complaint C ABI both with older and newer rustc versions.
…x, r=jhpratt impl `Default` for `array::IntoIter` cc rust-lang#91583 my personal use of this feature comes from https://github.com/fee1-dead/w/blob/092db5df631ea515b688bae99c7f02eef12d7221/src/cont.rs#L154-L170 insta-stable, but I feel like this is small enough to _not_ require an ACP (but a FCP per https://forge.rust-lang.org/libs/maintaining-std.html#when-theres-new-trait-impls)? feel free to correct me if I am wrong.
Add support for repetition to `proc_macro::quote` Progress toward: rust-lang#140238
…67, r=GuillaumeGomez rustdoc: make srcIndex no longer a global variable this is one-time initialization data, it can just be a function parameter. while we're doing that, we can more the json parsing into the function and save a few extra bytes of storage for free, at least in the case of multiple crates in a doc bundle. fixes rust-lang#138467
…s, r=petrochenkov avoid `&mut P<T>` in `visit_expr` etc methods trying a different way than rust-lang#141636 r? ghost
…lacrum Windows: Use anonymous pipes in Command When setting `Stdio::pipe` on `Command` we want to create an anonymous pipe that can be used asynchronously (at least on our end). Usually we'd use [`CreatePipe`](https://learn.microsoft.com/en-us/windows/win32/api/namedpipeapi/nf-namedpipeapi-createpipe) to open anonymous pipes but unfortunately it opens pipes for synchronous access. The alternative is to use [`CreateNamedPipeW`](https://learn.microsoft.com/en-us/windows/win32/api/namedpipeapi/nf-namedpipeapi-createnamedpipew) which does allow asynchronous access but that requires giving a file name to the pipe. So we currently have this awful hack where we attempt to emulate anonymous pipes using `CreateNamedPipeW` by attempting to create a unique name and looping until we find one that doesn't already exist. The better option is to use the lower level [`NtCreateNamedPipeFile`](https://learn.microsoft.com/en-us/windows/win32/devnotes/nt-create-named-pipe-file) (which is used internally by both `CreatePipe` and `CreateNamedPipeW`). This function wasn't documented until a few years ago but now that it is it's ok for us to use it. try-job: *msvc* try-job: *mingw*
alloc: less static mut + some cleanup I'm looking into rust-lang#125035 and would like some feedback on my approach.
Generic ctx imprv Cleanup work for my gpu pr r? `@oli-obk`
…li-obk Don't unwrap in enzyme builds in case of missing llvm-config r? `@onur-ozkan` For some reason x.py was now panicking in this location, so I also removed the unwrap here. part 2 of rust-lang#140000, there shouldn't be other locations where we check for llvm-config.
…rget-more-accurately, r=wesleywiser Refresh module-level docs for `rustc_target::spec` We have long since gone on a curveball from the flexible-target-specification RFC by introducing stability and soundness promises to the language and compiler which we often struggle with extending to target-specific implementation details. Indeed, we often *literally cannot*. We also have modified the search algorithm details. Update the comments for `rustc_target::spec` considerably.
…r=lolbinarycat Lint about `console` calls in rustdoc JS As discussed [here](rust-lang#142100 (comment)), this PR enforces that `console` is not used in rustdoc JS by default. cc `@lolbinarycat`
… r=jhpratt Remove a panicking branch in `BorrowedCursor::advance`
Dont suggest remove semi inside macro expansion for redundant semi lint Fixes rust-lang#142143 r? compiler
Update cargo 6 commits in fc1518ef02b77327d70d4026b95ea719dd9b8c51..2251525ae503fa196f6d7f9ce6d32eccb2d5f044 2025-06-06 04:49:44 +0000 to 2025-06-16 22:01:27 +0000 - feat: Add custom completer for `cargo remove <TAB>` (rust-lang/cargo#15662) - chore(deps): update msrv (3 versions) to v1.85 (rust-lang/cargo#15668) - refactor: replace InternedString with Cow in IndexPackage (rust-lang/cargo#15559) - highlight the correct words (rust-lang/cargo#15659) - CHANGELOG.md: typo (rust-lang/cargo#15660) - Use `Not::not` rather than a custom `is_false` function (rust-lang/cargo#15645)
…orkingjubilee Temporarily add back -Zwasm-c-abi=spec This allows a more gradual transition path for projects that need to use use the spec-complaint C ABI both with older and newer rustc versions.
rustbot
added
A-LLVM
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 27eb269 (parent) -> 77ec48f (this PR) Test differencesShow 147 test diffsStage 1
Stage 2
(and 41 additional test diffs) Additionally, 6 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 77ec48f5642ee1aa451d270f11f308c297f55f76 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 27eb2690f4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jun 18, 2025
|
Finished benchmarking commit (77ec48f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.4%, secondary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 693.336s -> 692.662s (-0.10%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Defaultforarray::IntoIter#141574 (implDefaultforarray::IntoIter)proc_macro::quote#141608 (Add support for repetition toproc_macro::quote)&mut P<T>invisit_expretc methods #142371 (avoid&mut P<T>invisit_expretc methods)rustc_target::spec#142608 (Refresh module-level docs forrustc_target::spec)consolecalls in rustdoc JS #142618 (Lint aboutconsolecalls in rustdoc JS)BorrowedCursor::advance#142620 (Remove a panicking branch inBorrowedCursor::advance)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup