Add bootstrap check snapshot tests #143316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
|
I'm still reviewing the original EDIT: done a review pass on the original PR, the general direction looks good to me 👍 |
jieyouxu
approved these changes
Jul 2, 2025
Comment on lines
182
to
186
| pub fn get_stage(&self) -> Option<u32> { | ||
| self.stage.or(self | ||
| .built_by | ||
| .map(|compiler| if self.name == "std" { compiler.stage } else { compiler.stage + 1 })) | ||
| } |
There was a problem hiding this comment.
Suggestion: maybe explicitly spell out the core model here?
Continuing from #143048 (review),
The stage numbering here has two cases:
- (compiler, library) will receive the same
$\mathrm{stage}$ number, because std is necessarily tightly coupled to the compiler. - For all other cases, they should be considered
$\mathrm{stage} + 1$ .
Comment on lines
+1273
to
+1275
| [build] rustc 0 <host> -> rustc 1 <host> | ||
| [build] rustc 1 <host> -> std 1 <host> | ||
| [check] rustc <host> |
There was a problem hiding this comment.
Question: I'm assuming the staging info is intended to be a follow-up (as in the overall PR) right?
As in, I'd expect the derivation chain for this to look like (overly simplified)
There was a problem hiding this comment.
Yeah. Right now, the check steps implicitly decide which compiler will build them, it's not represented explicitly in their Step parameters. Therefore it's also not easily representable in the step metadata.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup of 9 pull requests Successful merges: - #143192 (Improve CSS for source code block line numbers) - #143251 (bootstrap: add build.tidy-extra-checks option) - #143273 (Make the enum check work for negative discriminants) - #143292 (Explicitly handle all nodes in `generics_of` when computing parent) - #143316 (Add bootstrap check snapshot tests) - #143321 (byte-addresses memory -> byte-addressed memory) - #143324 (interpret: move the native call preparation logic into Miri) - #143325 (Use non-global interner in `test_string_interning` in bootstrap) - #143327 (miri: improve errors for type validity assertion failures) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup merge of #143316 - Kobzol:bootstrap-check-tests, r=jieyouxu Add bootstrap check snapshot tests Split off from #143048, so that we get a baseline of how check behaved before we make changes to it. Note that the output of the check snapshot tests is suboptimal in many places, as we're missing information about stages and the build compiler. That will be changed in #143048. r? `@jieyouxu`
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Jul 3, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#143192 (Improve CSS for source code block line numbers) - rust-lang/rust#143251 (bootstrap: add build.tidy-extra-checks option) - rust-lang/rust#143273 (Make the enum check work for negative discriminants) - rust-lang/rust#143292 (Explicitly handle all nodes in `generics_of` when computing parent) - rust-lang/rust#143316 (Add bootstrap check snapshot tests) - rust-lang/rust#143321 (byte-addresses memory -> byte-addressed memory) - rust-lang/rust#143324 (interpret: move the native call preparation logic into Miri) - rust-lang/rust#143325 (Use non-global interner in `test_string_interning` in bootstrap) - rust-lang/rust#143327 (miri: improve errors for type validity assertion failures) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #143048, so that we get a baseline of how check behaved before we make changes to it. Note that the output of the check snapshot tests is suboptimal in many places, as we're missing information about stages and the build compiler. That will be changed in #143048.
r? @jieyouxu