Correctly handle should_panic
doctest attribute
#143453
Open
+111
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143009.
Instead of checking the exit code, we directly wrap the doctest code with
catch_unwind
and if apanic
happened, then we return success for the test, otherwise we display the appropriate error message.I think last one who reviewed doctest changes was @fmease so setting you as reviewer. :)
r? fmease