-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix perf regression caused by tracing #143520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hopefully this will make tracing calls be optimized out properly when tracing is disabled
@bors2 try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Fix perf regression caused by tracing See #143334, this is another alternative that may be worth benchmarking as suggested in #143334 (comment). r? `@RalfJung` <!-- homu-ignore:start --> <!-- If this PR is related to an unstable feature or an otherwise tracked effort, please link to the relevant tracking issue here. If you don't know of a related tracking issue or there are none, feel free to ignore this. This PR will get automatically assigned to a reviewer. In case you would like a specific user to review your work, you can assign it to them by using r? <reviewer name> --> <!-- homu-ignore:end -->
No, this is not the closure I meant. I don't think this one will help. What I meant is an API of the form fn with_trace_span<R>(_span: tracing::Span, f: impl FnOnce() -> R) -> R { f() } I.e., the span ends when the closure returns. |
Queued 3ab9e25 with parent febb10d, future comparison URL. |
See #143334, this is another alternative that may be worth benchmarking as suggested in #143334 (comment).
r? @RalfJung